From 1b6748bc8b559bf757db287c1886d5852340457b Mon Sep 17 00:00:00 2001 From: Will Sheldon Date: Tue, 20 May 2025 18:09:47 -0700 Subject: [PATCH] fix: signal transaction management --- src/dispatch/signal/service.py | 3 --- src/dispatch/signal/views.py | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/dispatch/signal/service.py b/src/dispatch/signal/service.py index 061c84c58eb4..e9ae41638a44 100644 --- a/src/dispatch/signal/service.py +++ b/src/dispatch/signal/service.py @@ -192,8 +192,6 @@ def create_signal_instance(*, db_session: Session, signal_instance_in: SignalIns signal_instance_in.signal = signal_definition signal_instance = create_instance(db_session=db_session, signal_instance_in=signal_instance_in) - signal_instance.signal = signal_definition - return signal_instance @@ -720,7 +718,6 @@ def create_instance( signal_instance.oncall_service = oncall_service db_session.add(signal_instance) - db_session.commit() return signal_instance diff --git a/src/dispatch/signal/views.py b/src/dispatch/signal/views.py index 534158ea73f2..bb7684fcf6d6 100644 --- a/src/dispatch/signal/views.py +++ b/src/dispatch/signal/views.py @@ -117,6 +117,7 @@ def create_signal_instance( signal_instance = signal_service.create_instance( db_session=db_session, signal_instance_in=signal_instance_in ) + db_session.commit() except IntegrityError: msg = f"A signal instance with this id already exists. Id: {signal_instance_in.raw.get('id')}. Variant: {signal_instance_in.raw.get('variant')}" log.warn(msg)