replace Assembly.CodeBase by Assembly.Location

see https://docs.microsoft.com/en-us/dotnet/core/compatibility/syslib-warnings/syslib0012

Author: tibel

src/NetArchTest.Rules/Extensions/TypeExtensions.cs

@@ -21,9 +21,7 @@ public static TypeDefinition ToTypeDefinition(this Type type)
             var assembly = Assembly.GetAssembly(type);
 
             // Load the assembly into the Mono.Cecil library
-            UriBuilder uri = new UriBuilder(assembly.CodeBase);
-            string path = Uri.UnescapeDataString(uri.Path);
-            var assemblyDef = AssemblyDefinition.ReadAssembly(path);
+            var assemblyDef = AssemblyDefinition.ReadAssembly(assembly.Location);
 
             // Find the matching type
             var dependencies = (assemblyDef.Modules

src/NetArchTest.Rules/Types.cs

@@ -83,8 +83,7 @@ public static Types InAssemblies(IEnumerable<Assembly> assemblies, IEnumerable<s
                 if (!assembly.IsDynamic)
                 {
                     // Load the assembly using Mono.Cecil.
-                    UriBuilder uri = new UriBuilder(assembly.CodeBase);
-                    string path = Uri.UnescapeDataString(uri.Path);
+
 
                     AssemblyDefinition assemblyDef = null;
                     if (searchDirectories?.Any() ?? false)
@@ -95,11 +94,11 @@ public static Types InAssemblies(IEnumerable<Assembly> assemblies, IEnumerable<s
                             defaultAssemblyResolver.AddSearchDirectory(searchDirectory);
                         }
 
-                        assemblyDef = ReadAssemblyDefinition(path, new ReaderParameters { AssemblyResolver = defaultAssemblyResolver });
+                        assemblyDef = ReadAssemblyDefinition(assembly.Location, new ReaderParameters { AssemblyResolver = defaultAssemblyResolver });
                     }
                     else
                     { 
-                        assemblyDef = ReadAssemblyDefinition(path);
+                        assemblyDef = ReadAssemblyDefinition(assembly.Location);
                     }
 
                     // Read all the types in the assembly 
@@ -134,9 +133,7 @@ public static Types InNamespace(string name)
                 if (!assembly.IsDynamic)
                 {
                     // Load the assembly using Mono.Cecil.
-                    UriBuilder uri = new UriBuilder(assembly.CodeBase);
-                    string path = Uri.UnescapeDataString(uri.Path);
-                    var assemblyDef = ReadAssemblyDefinition(path);
+                    var assemblyDef = ReadAssemblyDefinition(assembly.Location);
 
                     if (assemblyDef != null)
                     {