remove HaveDependencyOn and DoNotHaveDependencyOn

Author: NeVeSpl

samples/NetArchTest.SampleRules/ExamplePolicies.cs

@@ -22,11 +22,11 @@ public static void Run()
                    t.That()
                    .ResideInNamespace("NetArchTest.SampleLibrary.Presentation")
                    .ShouldNot()
-                   .HaveDependencyOn("NetArchTest.SampleLibrary.Data"),
+                   .HaveDependencyOnAny("NetArchTest.SampleLibrary.Data"),
                    "Enforcing layered architecture", "Controllers should not directly reference repositories"
                 )
                 .Add(t =>
-                    t.That().HaveDependencyOn("System.Data")
+                    t.That().HaveDependencyOnAny("System.Data")
                     .And().ResideInNamespace(("ArchTest"))
                     .Should().ResideInNamespace("NetArchTest.SampleLibrary.Data"),
                     "Controlling external dependencies", "Only classes in the data namespace can have a dependency on System.Data"

samples/NetArchTest.SampleRules/ExampleRules.cs

@@ -20,7 +20,7 @@ public static void Run()
                 .That()
                 .ResideInNamespace("NetArchTest.SampleLibrary.Presentation")
                 .ShouldNot()
-                .HaveDependencyOn("NetArchTest.SampleLibrary.Data")
+                .HaveDependencyOnAny("NetArchTest.SampleLibrary.Data")
                 .GetResult().IsSuccessful;
 
             //****************************************************
@@ -29,7 +29,7 @@ public static void Run()
             // Only classes in the data namespace can have a dependency on System.Data
 
             result = Types.InCurrentDomain()
-                .That().HaveDependencyOn("System.Data")
+                .That().HaveDependencyOnAny("System.Data")
                 .And().ResideInNamespace(("ArchTest"))
                 .Should().ResideInNamespace(("NetArchTest.SampleLibrary.Data"))
                 .GetResult().IsSuccessful;

src/NetArchTest.Rules/Condition.cs

@@ -599,18 +599,7 @@ public ConditionList NotResideInNamespaceContaining(string name)
         {
             _sequence.AddFunctionCall(FunctionDelegates.ResideInNamespaceMatching, $"^.*{name}.*$", false);
             return new ConditionList(_types, _should, _sequence);
-        }
-
-        /// <summary>
-        /// Selects types that have a dependency on a particular type.
-        /// </summary>
-        /// <param name="dependency">The dependency to match against. This can be a namespace or a specific type.</param>
-        /// <returns>An updated set of conditions that can be applied to a list of types.</returns>
-        public ConditionList HaveDependencyOn(string dependency)
-        {
-            _sequence.AddFunctionCall(FunctionDelegates.HaveDependencyOnAny, new List<string> { dependency }, true);
-            return new ConditionList(_types, _should, _sequence);
-        }
+        }        
 
         /// <summary>
         /// Selects types that have a dependency on any of the supplied types.
@@ -644,17 +633,7 @@ public ConditionList OnlyHaveDependenciesOn(params string[] dependencies)
             _sequence.AddFunctionCall(FunctionDelegates.OnlyHaveDependenciesOnAnyOrNone, dependencies, true);
             return new ConditionList(_types, _should, _sequence);
         }
-
-        /// <summary>
-        /// Selects types that do not have a dependency on a particular type.
-        /// </summary>
-        /// <param name="dependency">The dependency type to match against. This can be a namespace or a specific type.</param>
-        /// <returns>An updated set of conditions that can be applied to a list of types.</returns>
-        public ConditionList NotHaveDependencyOn(string dependency)
-        {
-            _sequence.AddFunctionCall(FunctionDelegates.HaveDependencyOnAny, new List<string> { dependency }, false);
-            return new ConditionList(_types, _should, _sequence);
-        }
+      
         /// <summary>
         /// Selects types that do not have a dependency on any of the particular types.
         /// </summary>

src/NetArchTest.Rules/Predicate.cs

@@ -615,18 +615,7 @@ public PredicateList DoNotResideInNamespaceContaining(string name)
         {
             _sequence.AddFunctionCall(FunctionDelegates.ResideInNamespaceMatching, $"^.*{name}.*$", false);
             return new PredicateList(_types, _sequence);
-        }
-
-        /// <summary>
-        /// Selects types that have a dependency on a particular type.
-        /// </summary>
-        /// <param name="dependency">The dependency type to match against. This can be a namespace or a specific type.</param>
-        /// <returns>An updated set of predicates that can be applied to a list of types.</returns>
-        public PredicateList HaveDependencyOn(string dependency)
-        {
-            _sequence.AddFunctionCall(FunctionDelegates.HaveDependencyOnAny, new List<string> { dependency }, true);
-            return new PredicateList(_types, _sequence);
-        }
+        }    
 
         /// <summary>
         /// Selects types that have a dependency on any of the supplied types.
@@ -659,18 +648,7 @@ public PredicateList OnlyHaveDependenciesOn(params string[] dependencies)
         {
             _sequence.AddFunctionCall(FunctionDelegates.OnlyHaveDependenciesOnAnyOrNone, dependencies, true);
             return new PredicateList(_types, _sequence);
-        }
-
-        /// <summary>
-        /// Selects types that do not have a dependency on a particular type.
-        /// </summary>
-        /// <param name="dependency">The dependency type to match against. This can be a namespace or a specific type.</param>
-        /// <returns>An updated set of predicates that can be applied to a list of types.</returns>
-        public PredicateList DoNotHaveDependencyOn(string dependency)
-        {
-            _sequence.AddFunctionCall(FunctionDelegates.HaveDependencyOnAny, new List<string> { dependency }, false);
-            return new PredicateList(_types, _sequence);
-        }
+        }      
 
         /// <summary>
         /// Selects types that do not have a dependency on any of the particular types.

test/NetArchTest.Rules.UnitTests/ConditionTests.cs

@@ -826,7 +826,7 @@ public void HaveDependency_MatchesFound_ClassSelected()
                 .And()
                 .HaveNameStartingWith("HasDepend")
                 .Should()
-                .HaveDependencyOn(typeof(ExampleDependency).FullName)
+                .HaveDependencyOnAny(typeof(ExampleDependency).FullName)
                 .GetResult();
 
             Assert.True(result.IsSuccessful);
@@ -890,7 +890,7 @@ public void NotHaveDependency_MatchesFound_ClassSelected()
                 .And()
                 .HaveNameStartingWith("NoDependency")
                 .Should()
-                .NotHaveDependencyOn(typeof(ExampleDependency).FullName)
+                .NotHaveDependencyOnAny(typeof(ExampleDependency).FullName)
                 .GetResult();
 
             Assert.True(result.IsSuccessful);

test/NetArchTest.Rules.UnitTests/PredicateTests.cs

@@ -940,7 +940,7 @@ public void HaveDepencency_MatchesFound_ClassSelected()
                 .That()
                 .ResideInNamespace(typeof(HasDependency).Namespace)
                 .And()
-                .HaveDependencyOn(typeof(ExampleDependency).FullName)
+                .HaveDependencyOnAny(typeof(ExampleDependency).FullName)
                 .GetTypes();
 
             Assert.Equal(2, result.Count()); // Two types found
@@ -1004,7 +1004,7 @@ public void DoNotHaveDepencency_MatchesFound_ClassSelected()
                 .That()
                 .ResideInNamespace(typeof(HasDependency).Namespace)
                 .And()
-                .DoNotHaveDependencyOn(typeof(ExampleDependency).FullName)
+                .DoNotHaveDependencyOnAny(typeof(ExampleDependency).FullName)
                 .GetTypes();
 
             Assert.Equal(2, result.Count()); // Two types found