bug: CLI's `route-server remove` does not seem to work

[fengzhou-nv]

Version

0.8.0

Describe the bug.

nico-cli route-server remove did not seem to work when tried removing a route server. The CLI returned success. However, nico-cli route-server get still shows the route server IP.

Minimum reproducible example

(IPs changed for illustrative purpose only, forge-admin-cli is an alias of nico's cli)

❯ forge-admin-cli route-server remove 1.1.1.2

❯ forge-admin-cli route-server get
+--------------+-------------+
| Address      | Source Type |
+--------------+-------------+
| 1.1.1.1      | ConfigFile  |
+--------------+-------------+
| 1.1.1.2      | ConfigFile  |
+--------------+-------------+
| 1.1.1.3      | ConfigFile  |
+--------------+-------------+

Relevant log output

Other/Misc.

No response

Code of Conduct

• I agree to follow NVIDIA Infra Controller's Code of Conduct
• I have searched the open bugs and have found no duplicates for this bug report

[hatamzad-nv]

Fixed in #4131.

The CLI defaults --source-type to admin_api, but these were config_file entries, so the delete matched nothing and still returned success. It now returns an error when nothing matched.

The scoping is intentional, so use --source-type config_file to remove config-file entries.