From b118332ac28cdff0ee755b8a7ceaa6003fbd4d09 Mon Sep 17 00:00:00 2001 From: Prekshi Vyas Date: Tue, 6 Oct 2026 13:01:23 -0700 Subject: [PATCH 1/2] ci: allow native gateway restart evidence for PR 12591 Signed-off-by: Prekshi Vyas --- ci/e2e-assertion-growth-exceptions.json | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ci/e2e-assertion-growth-exceptions.json b/ci/e2e-assertion-growth-exceptions.json index d472223a346..2457401c9e3 100644 --- a/ci/e2e-assertion-growth-exceptions.json +++ b/ci/e2e-assertion-growth-exceptions.json @@ -1,5 +1,5 @@ { - "$comment": "SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.\nSPDX-License-Identifier: Apache-2.0\n\nMaintainer-approved exception for the exact PR #10341 budget transition. Adds only deferred-onboarding.test.ts with [12,14,12,14,0]; existing per-file budgets remain unchanged. Approval: https://github.com/NVIDIA/NemoClaw/pull/10341#issuecomment-5799263232. Local hooks and candidate CI may use this branch policy. The independent PR check reads only trusted base policy, so its expected growth failure is explicitly waived for #10341. A changed base or candidate budget invalidates this exception. Remove after #10341 merges.\n\nPR #12305 adds 19 live assertion points for the approved stopped-container recovery proof while retaining healthy-rebuild coverage. Exact budget-transition approval: https://github.com/NVIDIA/NemoClaw/pull/12305#issuecomment-5803852010. No other budget transition is accepted by this entry.\n\nThe same 19-assertion helper is also exercised by rebuild-openclaw, independently of the inherited private-MCP failure. Unique assertion counts are unchanged; one helper file is extracted. Revised exact-transition approval: https://github.com/NVIDIA/NemoClaw/pull/12305#issuecomment-5807159038.", + "$comment": "SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.\nSPDX-License-Identifier: Apache-2.0\n\nMaintainer-approved exception for the exact PR #10341 budget transition. Adds only deferred-onboarding.test.ts with [12,14,12,14,0]; existing per-file budgets remain unchanged. Approval: https://github.com/NVIDIA/NemoClaw/pull/10341#issuecomment-5799263232. Local hooks and candidate CI may use this branch policy. The independent PR check reads only trusted base policy, so its expected growth failure is explicitly waived for #10341. A changed base or candidate budget invalidates this exception. Remove after #10341 merges.\n\nPR #12305 adds 19 live assertion points for the approved stopped-container recovery proof while retaining healthy-rebuild coverage. Exact budget-transition approval: https://github.com/NVIDIA/NemoClaw/pull/12305#issuecomment-5803852010. No other budget transition is accepted by this entry.\n\nThe same 19-assertion helper is also exercised by rebuild-openclaw, independently of the inherited private-MCP failure. Unique assertion counts are unchanged; one helper file is extracted. Revised exact-transition approval: https://github.com/NVIDIA/NemoClaw/pull/12305#issuecomment-5807159038.\n\nProposed exact budget transition for PR #12591: replace a restart progress-message check with a native gateway-owner observation before and after inference switching. Adds one generated probe and five probe conditions; direct and unique expectation counts do not exceed main. The imported helper also appears in the full-e2e transitive inventory. This entry requires maintainer review before landing on main. Remove it after #12591 merges.", "schemaVersion": 1, "exceptions": [ { @@ -11,6 +11,11 @@ "pullRequest": 12305, "baseBudgetSha256": "375c8f76724ccade48d8bbaafddc582984270350f95efde51211b0ff973a9dbe", "headBudgetSha256": "a2950bb3b5be2ba76071f3956b8a9a30fb4f3877308542c3947cea3821bfdf28" + }, + { + "pullRequest": 12591, + "baseBudgetSha256": "d0a41e5514e5cc2f7bb34d7604c82106d9e36239f1abf5859e343c7733501289", + "headBudgetSha256": "59c006401487a0c25d9f5cf5fd3159c9f1248a6710d559cc18879af6edef2919" } ] } From e6da4498e0411a62e7e5dd36dca18ebc2fb48ee3 Mon Sep 17 00:00:00 2001 From: Prekshi Vyas Date: Tue, 6 Oct 2026 13:25:41 -0700 Subject: [PATCH 2/2] test(cli): avoid secret markers in status fixture names --- test/cli/status-root-json.test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/cli/status-root-json.test.ts b/test/cli/status-root-json.test.ts index 42612c7b71e..54372aa9403 100644 --- a/test/cli/status-root-json.test.ts +++ b/test/cli/status-root-json.test.ts @@ -14,7 +14,8 @@ describe("CLI root status JSON", () => { const home = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-cli-status-json-")); const localBin = path.join(home, "bin"); const registryDir = path.join(home, ".nemoclaw"); - const sandboxName = `a-${process.pid.toString(36).slice(-3)}-${Date.now().toString(36).slice(-8)}`; + // Hexadecimal names cannot contain the credential markers checked below. + const sandboxName = `a-${process.pid.toString(16)}-${Date.now().toString(16).slice(-8)}`; const serviceDir = path.join("/tmp", `nemoclaw-services-${sandboxName}`); fs.rmSync(serviceDir, { recursive: true, force: true }); fs.mkdirSync(localBin, { recursive: true });