From 926ba01f52effe81a179566fabaa8927c1fb3fe2 Mon Sep 17 00:00:00 2001 From: Midga3 Date: Tue, 10 Nov 2026 18:27:05 +0300 Subject: [PATCH 1/3] Add ESLint workflow for pull requests --- .github/workflows/test.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/workflows/test.yml diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml new file mode 100644 index 000000000..a878ea954 --- /dev/null +++ b/.github/workflows/test.yml @@ -0,0 +1,11 @@ +name: PR Rules +on: [pull_request] +jobs: + eslint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: { node-version: 20, cache: npm } + - run: npm ci + - run: npx eslint . --ext .js,.html From 8d55aba4fdc400fd660e50d653fe5d9c37c9590a Mon Sep 17 00:00:00 2001 From: Midga3 Date: Tue, 10 Nov 2026 18:32:06 +0300 Subject: [PATCH 2/3] Update test.yml --- .github/workflows/test.yml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a878ea954..770f243dd 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,5 +1,6 @@ -name: PR Rules +name: Check PR on: [pull_request] + jobs: eslint: runs-on: ubuntu-latest @@ -8,4 +9,13 @@ jobs: - uses: actions/setup-node@v4 with: { node-version: 20, cache: npm } - run: npm ci - - run: npx eslint . --ext .js,.html + - id: changed + uses: tj-actions/changed-files@v45 + with: + files: | + **/*.js + - if: steps.changed.outputs.any_changed == 'true' + run: | + npx eslint ${{ steps.changed.outputs.all_changed_files }} \ + --no-eslintrc \ + --rule '{"rovalra/restricted-syntax-verified": ["error", {"selector":"AssignmentExpression[left.property.name=\"innerHTML\"]:not([right.type=\"Literal\"]):not([right.type=\"TemplateLiteral\"][right.expressions.length=0]):not([right.callee.property.name=\"sanitize\"]):not([right.callee.name=\"sanitize\"]):not([right.tag.name=\"safeHtml\"])","message":"⚠️ Unsafe innerHTML"}]}' From 596b625c8128b200a2b23f80c9fd05ddf965a5f8 Mon Sep 17 00:00:00 2001 From: Midga3 Date: Tue, 10 Nov 2026 18:48:23 +0300 Subject: [PATCH 3/3] insane --- .github/workflows/test.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 770f243dd..e2e103eff 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,6 +16,12 @@ jobs: **/*.js - if: steps.changed.outputs.any_changed == 'true' run: | - npx eslint ${{ steps.changed.outputs.all_changed_files }} \ - --no-eslintrc \ - --rule '{"rovalra/restricted-syntax-verified": ["error", {"selector":"AssignmentExpression[left.property.name=\"innerHTML\"]:not([right.type=\"Literal\"]):not([right.type=\"TemplateLiteral\"][right.expressions.length=0]):not([right.callee.property.name=\"sanitize\"]):not([right.callee.name=\"sanitize\"]):not([right.tag.name=\"safeHtml\"])","message":"⚠️ Unsafe innerHTML"}]}' + set +e + OUTPUT=$(npx eslint ${{ steps.changed.outputs.all_changed_files }} 2>&1) + set -e + echo "$OUTPUT" + if echo "$OUTPUT" | grep -q "Unsafe innerHTML"; then + echo "::error::Unsafe innerHTML found in changed files" + exit 1 + fi + echo "No innerHTML issues"