review update and Ex8 code fixes

Author: ChrisHowd

DownloadableCodeProjects/standalone-lab-projects/refactor-large-functions/ECommerceOrderProcessing/src/ECommerce.ApplicationCore/Services/OrderProcessor.cs

@@ -4,7 +4,7 @@
 namespace ECommerce.ApplicationCore.Services;
 
 /// <summary>
-/// Main order processing service containing the large method that needs refactoring
+/// Main order processing service
 /// </summary>
 public class OrderProcessor
 {
@@ -32,9 +32,6 @@ public OrderProcessor(
     }
 
     /// <summary>
-    /// LARGE METHOD INTENTIONALLY KEPT FOR REFACTORING DEMONSTRATION
-    /// This method contains multiple responsibilities and should be refactored into smaller methods
-    /// 
     /// Responsibilities include:
     /// 1. Input Validation & Security Checks
     /// 2. Inventory Management
@@ -52,7 +49,7 @@ public OrderResult ProcessOrder(Order order)
 
         try
         {
-            // Step 1: Comprehensive Input Validation and Security Checks
+            // Comprehensive Input Validation and Security Checks
             if (order == null)
             {
                 _auditLogger.LogSecurityEvent("NULL_ORDER_ATTEMPT", "Attempted to process null order");
@@ -104,7 +101,7 @@ public OrderResult ProcessOrder(Order order)
             Console.WriteLine($"Processing Order {order.Id} for {_securityValidator.MaskEmail(order.CustomerEmail)}...");
             Console.WriteLine($"Order contains {order.Items.Count} items, Total: ${order.TotalAmount:F2}");
 
-            // Step 2: Inventory Management - Check Stock Availability and Reserve Items
+            // Inventory Management - Check Stock Availability and Reserve Items
             Console.WriteLine("Checking inventory availability...");
             foreach (OrderItem item in order.Items)
             {
@@ -135,7 +132,7 @@ public OrderResult ProcessOrder(Order order)
             Console.WriteLine("Inventory reserved successfully.");
             _auditLogger.LogInventoryReserved(order.Id, order.Items.Count);
 
-            // Step 3: Payment Processing with Enhanced Security
+            // Payment Processing with Enhanced Security
             Console.WriteLine("Processing payment...");
             try
             {
@@ -162,7 +159,7 @@ public OrderResult ProcessOrder(Order order)
                 return OrderResult.Failure("Payment processing failed: " + ex.Message);
             }
 
-            // Step 4: Shipping and Logistics Management
+            // Shipping and Logistics Management
             Console.WriteLine("Scheduling shipping...");
             try
             {
@@ -186,7 +183,7 @@ public OrderResult ProcessOrder(Order order)
                 return OrderResult.Failure("Shipping scheduling failed: " + ex.Message);
             }
 
-            // Step 5: Customer Communication and Notifications
+            // Customer Communication and Notifications
             Console.WriteLine("Sending notifications...");
             try
             {
@@ -209,7 +206,7 @@ public OrderResult ProcessOrder(Order order)
                 Console.WriteLine($"Warning: failed to send notification: {ex.Message}");
             }
 
-            // Step 6: Order Finalization and Data Recording
+            // Order Finalization and Data Recording
             Console.WriteLine("Finalizing order...");
             order.Status = OrderStatus.Completed;
             order.CompletionDate = DateTime.UtcNow;

DownloadableCodeProjects/standalone-lab-projects/refactor-large-functions/ECommerceOrderProcessing/src/ECommerce.Console/Program.cs

@@ -46,7 +46,7 @@ public static void Main(string[] args)
             { 
                 CardNumber = "4111111111111111", 
                 CardCVV = "123", 
-                CardHolderName = "John Doe",
+                CardHolderName = "Ane Pedersen",
                 ExpiryMonth = "12",
                 ExpiryYear = "2025",
                 BillingAddress = "123 Main St, City, State 12345"
@@ -58,23 +58,23 @@ public static void Main(string[] args)
         System.Console.WriteLine("\n--- Test Case 2: Invalid Email Address ---");
         var invalidEmailOrder = CreateSampleOrder("ORD-002", "invalid-email", "123 Main St", 
             new List<OrderItem> { new() { ProductId = "BOOK-001", Quantity = 1, Price = 15.99m } },
-            new PaymentInfo { CardNumber = "4111111111111111", CardCVV = "123", CardHolderName = "Jane Smith", ExpiryMonth = "06", ExpiryYear = "2026", BillingAddress = "123 Main St" });
+            new PaymentInfo { CardNumber = "4111111111111111", CardCVV = "123", CardHolderName = "Jennet Nazarowa", ExpiryMonth = "06", ExpiryYear = "2026", BillingAddress = "123 Main St" });
 
         var result2 = processor.ProcessOrder(invalidEmailOrder);
         testResults.Add($"Test 2: {(result2.IsSuccess ? "FAILED" : "PASSED")} - Should reject invalid email");
 
         System.Console.WriteLine("\n--- Test Case 3: Declined Payment ---");
         var declinedPaymentOrder = CreateSampleOrder("ORD-003", "customer@test.com", "456 Oak Ave", 
             new List<OrderItem> { new() { ProductId = "PHONE-001", Quantity = 1, Price = 699.99m } },
-            new PaymentInfo { CardNumber = "0000000000000000", CardCVV = "999", CardHolderName = "Test User", ExpiryMonth = "01", ExpiryYear = "2024", BillingAddress = "456 Oak Ave" });
+            new PaymentInfo { CardNumber = "0000000000000000", CardCVV = "999", CardHolderName = "Nikki Vestergaard", ExpiryMonth = "01", ExpiryYear = "2024", BillingAddress = "456 Oak Ave" });
 
         var result3 = processor.ProcessOrder(declinedPaymentOrder);
         testResults.Add($"Test 3: {(result3.IsSuccess ? "FAILED" : "PASSED")} - Should reject declined payment");
 
         System.Console.WriteLine("\n--- Test Case 4: Suspicious Order (Security Check) ---");
-        var suspiciousOrder = CreateSampleOrder("ORD-004", "suspicious@temp.com", "Unknown Location", 
-            new List<OrderItem> { new() { ProductId = "EXPENSIVE-001", Quantity = 10, Price = 5000.00m } },
-            new PaymentInfo { CardNumber = "4111111111111111", CardCVV = "000", CardHolderName = "A", ExpiryMonth = "12", ExpiryYear = "2025", BillingAddress = "Unknown Location" });
+        var suspiciousOrder = CreateSampleOrder("ORD-004", "suspicious.user@valid.com", "123 Suspicious Ave, City, State 99999", 
+            new List<OrderItem> { new() { ProductId = "EXPENSIVE-001", Quantity = 2, Price = 25000.00m } },
+            new PaymentInfo { CardNumber = "4111111111111111", CardCVV = "123", CardHolderName = "AB", ExpiryMonth = "12", ExpiryYear = "2026", BillingAddress = "123 Suspicious Ave, City, State 99999" });
 
         var result4 = processor.ProcessOrder(suspiciousOrder);
         testResults.Add($"Test 4: {(result4.IsSuccess ? "FAILED" : "PASSED")} - Should flag suspicious order");

Instructions/Labs/LAB_AK_07_consolidate_duplicate_code.md

@@ -86,7 +86,7 @@ Use the following steps to download the sample project and open it in Visual Stu
 
     1. Navigate to the Windows Desktop folder, select **GHCopilotEx7LabApps** and then select **Select Folder**.
 
-1. In the Visual Studio Code SOLUTION EXPLORER view, verify the following solution structure:
+1. In the Visual Studio Code SOLUTION EXPLORER view, verify the following project structure:
 
     - GHCopilotEx7LabApps\
         - ECommerceOrderAndReturn\

Instructions/Labs/LAB_AK_08_refactor_large_functions.md

@@ -86,15 +86,21 @@ Use the following steps to download the sample project and open it in Visual Stu
 
     1. Navigate to the Windows Desktop folder, select **GHCopilotEx8LabApps** and then select **Select Folder**.
 
-1. In the Visual Studio Code SOLUTION EXPLORER view, verify the following solution structure:
+1. In the Visual Studio Code SOLUTION EXPLORER view, verify the following project structure:
 
     - GHCopilotEx8LabApps\
         - ECommerceOrderProcessing\
             - src\
                 - ECommerce.ApplicationCore\
-                - ECommerce.Infrastructure\
+                    - Entities\
+                    - Interfaces\
+                    - Services\
                 - ECommerce.Console\
-            - ECommerceOrderProcessing.sln
+                    - order_audit_log.txt
+                    - Program.cs
+                - ECommerce.Infrastructure\
+                    - Services\
+        - ServerLogAnalysisUtility\
 
 ## Exercise scenario
 
@@ -125,18 +131,12 @@ Use the following steps to complete this task:
 
     The codebase follows a layered architecture pattern with three main projects:
 
-    - **ECommerce.ApplicationCore**: Contains domain entities, business logic interfaces, and the main `OrderProcessor` service
-    - **ECommerce.Infrastructure**: Contains service implementations for external integrations (payment, shipping, inventory, etc.)
+    - **ECommerce.ApplicationCore**: Contains domain entities, business logic interfaces, and the main `OrderProcessor` service.
     - **ECommerce.Console**: Contains the console application entry point and dependency injection setup
+    - **ECommerce.Infrastructure**: Contains service implementations for external integrations (payment, shipping, inventory, etc.).
 
     This structure represents a real-world .NET application using Clean Architecture principles, where business logic is separated from infrastructure concerns.
 
-1. Verify that the **ECommerceOrderProcessing** solution builds successfully.
-
-    For example, in the SOLUTION EXPLORER view, right-click **ECommerceOrderProcessing.sln**, and then select **Build**.
-
-    You should see a successful build with no errors. This confirms that all project dependencies are properly configured.
-
 1. Open the GitHub Copilot Chat view.
 
     If the Chat view isn't already open, you can open it by selecting the **Chat** icon at the top of the Visual Studio Code window.
@@ -149,19 +149,13 @@ Use the following steps to complete this task:
 
 1. In Visual Studio Code, navigate to **src/ECommerce.ApplicationCore/Services/OrderProcessor.cs**.
 
-    This file contains the `OrderProcessor` class with the large `ProcessOrder` method that you'll be refactoring. The method is over 200 lines long and handles multiple responsibilities including validation, security checks, inventory management, payment processing, shipping, notifications, and order finalization.
+1. Open the OrderProcessor.cs file in the code editor.
 
-1. Locate the **ProcessOrder** method in the **OrderProcessor** class.
+    The OrderProcessor.cs file provides the main order processing service for the app.
 
-    The `ProcessOrder` method represents the core business logic for processing customer orders. Notice that it handles multiple distinct operations:
+1. Take a minute to review the **OrderProcessor** class.
 
-    - **Input validation and security checks**: Email validation, address validation, payment info validation, risk assessment
-    - **Inventory management**: Stock checking and reservation with rollback on failures
-    - **Payment processing**: Secure payment validation and processing with fraud detection
-    - **Shipping coordination**: Shipment scheduling and tracking number generation  
-    - **Customer notifications**: Email confirmations and high-value order alerts
-    - **Order finalization**: Status updates, completion tracking, and audit logging
-    - **Error handling**: Comprehensive exception management with cleanup procedures
+    Notice the ProcessOrder method. This method represents the core business logic for processing customer orders. Notice that it handles multiple distinct operations.
 
     The method is intentionally large and complex to demonstrate real-world scenarios where business logic has accumulated over time, making it difficult to read, test, and maintain.
 
@@ -175,7 +169,11 @@ Use the following steps to complete this task:
 
 1. Run the application to understand its current behavior.
 
-    Navigate to the **src/ECommerce.Console** folder in the terminal and run:
+    For example:
+
+    In the SOLUTION EXPLORER view, right-click the **ECommerce.Console** project, select **Debug**, and then select **Start New Instance**.
+
+    You can also navigate to the **src/ECommerce.Console** folder in the terminal and run:
 
     ```bash
     dotnet run

Instructions/Labs/LAB_AK_09_simplify_complex_conditionals.md

@@ -86,7 +86,7 @@ Use the following steps to download the sample projects and open them in Visual
 
     1. Navigate to the Windows Desktop folder, select **GHCopilotEx9LabApps** and then select **Select Folder**.
 
-1. In the Visual Studio Code SOLUTION EXPLORER view, verify the following solution structure:
+1. In the Visual Studio Code SOLUTION EXPLORER view, verify the following project structure:
 
     - GHCopilotEx9LabApps\
         - ECommercePricingEngine\