From d69768a70274e6c894c534ced6529fc6a5fa5d82 Mon Sep 17 00:00:00 2001 From: Jongsun Suh Date: Mon, 14 Sep 2026 07:17:14 -0400 Subject: [PATCH] Point `ab-testing` at the fixture method that exists `FixtureBuilder.withRemoteFeatureFlags(...)` does not exist in `metamask-extension`. Specs call `withRemoteFeatureFlagController` on `FixtureBuilderV2`, with the flags nested under `remoteFeatureFlags`, so the argument shape changes along with the name. --- .../testing/skills/ab-testing/repos/metamask-extension.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/domains/testing/skills/ab-testing/repos/metamask-extension.md b/domains/testing/skills/ab-testing/repos/metamask-extension.md index d6a06723..db147cc3 100644 --- a/domains/testing/skills/ab-testing/repos/metamask-extension.md +++ b/domains/testing/skills/ab-testing/repos/metamask-extension.md @@ -74,9 +74,9 @@ const activeABTests = experiment.isActive - Register every new remote A/B test flag in `test/e2e/feature-flags/feature-flag-registry.ts` with the production default threshold-array JSON value. - - Use test overrides such as `manifestFlags.remoteFeatureFlags` or - `FixtureBuilder.withRemoteFeatureFlags(...)` when a test needs - deterministic assignment. + - Use test overrides such as `manifestFlags.remoteFeatureFlags`, or + `withRemoteFeatureFlagController({ remoteFeatureFlags: { ... } })` on + `FixtureBuilderV2`, when a test needs deterministic assignment. - If the change is copy-only or config-only, you may skip new tests with a brief rationale. 7. Run the A/B compliance checker using the repository's current supported invocation and report the result.