Skip to content

Commit 1494de5

Browse files
committed
Use /bin/bash in the absorbed tests and name the real function in a comment
`test/cli.test.mjs` spawned bare `bash` at two of its seven call sites, the two absorbed from #94. Copilot raised exactly this on `:287` and it was answered `Fixed: 7adfa62`; the absorption reintroduced it. The comment above the same file's citation-convention suite named `copy_cited_knowledge`, which does not exist — the function is `resolve_foreign_knowledge` at `tools/install:376`.
1 parent 55b6d4d commit 1494de5

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎test/cli.test.mjs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ describe('corpus: knowledge citations resolve within their own domain', () => {
368368
// This asserts a SOURCE-TREE convention: a skill cites knowledge from its own domain,
369369
// so the citation is readable in this repo without knowing the installer. It is not the
370370
// same property as "does the operator receive the file" — the installer now delivers
371-
// cross-domain knowledge (`copy_cited_knowledge`, below), so every entry in the list
371+
// cross-domain knowledge (`resolve_foreign_knowledge`, below), so every entry in the list
372372
// resolves for an operator while still breaking the convention here.
373373
//
374374
// Saying that precisely matters, because the earlier version of this comment claimed the
@@ -582,7 +582,7 @@ describe('cross-domain knowledge references', () => {
582582

583583
test('a skill receives knowledge it cites from another domain', () => {
584584
const result = spawnSync(
585-
'bash',
585+
'/bin/bash',
586586
[INSTALL, '--target', target, '--repo', 'core', '--source', source],
587587
{ encoding: 'utf8' },
588588
);
@@ -618,7 +618,7 @@ describe('cross-domain knowledge references', () => {
618618
source = saved;
619619

620620
const result = spawnSync(
621-
'bash',
621+
'/bin/bash',
622622
[INSTALL, '--target', clashTarget, '--repo', 'core', '--source', clashSource],
623623
{ encoding: 'utf8' },
624624
);

0 commit comments

Comments
 (0)