From fc4b94884dfeb9dc38f521596a448b44ef7d17b9 Mon Sep 17 00:00:00 2001 From: R0ck Date: Tue, 1 Sep 2026 21:53:51 +0100 Subject: [PATCH] build: the cross-builds compile, and the comment stops saying they do not The comment claimed Windows and macOS did not compile and that only linux-amd64 was live. Both have shipped real binaries since August, selected by the PLATFORMS repository variable, which is set to all three. A comment that calls a working path broken costs more than a missing one: the next reader believes the cross-builds are unavailable and reaches for a native runner for each platform, which is the opposite of what this workflow does. The fallback stays at linux-amd64 and now says why, rather than implying it is a limitation. The radioserver note is corrected the same way: nothing blocks it today, and the reason it was never blocked is the part worth keeping. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01Q9HbD44EKWWTRYgxbFGxf6 --- .github/workflows/build.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3e58c5f..aeb5578 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,16 +27,17 @@ permissions: env: UPSTREAM: meshcore-dev/MeshCore - # Which platforms to publish. Only linux-amd64 is live: the Windows and macOS - # cross-builds do not compile yet (MSIM-44), and shipping a release that is - # missing two thirds of its matrix every night is noise rather than signal. - # Widen it with the PLATFORMS repository variable, no commit needed. + # Which platforms to publish. All three build today, and the PLATFORMS + # repository variable is set to all three, so that is what a release carries. + # The fallback below stays at linux-amd64 because it is the one target needing + # no cross toolchain: a fork with the variable unset should publish something + # rather than fail nightly on two it was never set up for. PLATFORMS: ${{ vars.PLATFORMS || 'linux-amd64' }} - # radioserver builds for platforms a node binary cannot. It is one translation - # unit against VirtualSX1262 with no Arduino shims and no Crypto, so the - # Windows and macOS builds that MSIM-44 blocks for firmware work here today — - # which matters, because an operator on a Mac needs this one piece even when - # every node they run is a Linux binary under emulation. + # radioserver built for every platform back when the firmware cross-builds + # still did not. It is one translation unit against VirtualSX1262 with no + # Arduino shims and no Crypto, which is why nothing ever blocked it, and it + # matters because an operator on a Mac needs this one piece even when every + # node they run is a Linux binary under emulation. RADIOSERVER_PLATFORMS: ${{ vars.RADIOSERVER_PLATFORMS || 'linux-amd64 darwin-arm64 windows-amd64' }} jobs: