disable error raise on users without email in julia

Author: mustafasoylu

src/somesy/julia/models.py

@@ -1,6 +1,7 @@
 """Julia model."""
 
 import uuid
+from logging import getLogger
 from typing import Optional, Set
 
 from packaging.version import parse as parse_version
@@ -9,11 +10,13 @@
     EmailStr,
     Field,
     TypeAdapter,
+    ValidationError,
     field_validator,
 )
 from typing_extensions import Annotated
 
 EMailAddress = TypeAdapter(EmailStr)
+logger = getLogger("somesy")
 
 
 class JuliaConfig(BaseModel):
@@ -48,15 +51,25 @@ def validate_version(cls, v):
     @field_validator("authors")
     @classmethod
     def validate_email_format(cls, v):
-        """Validate email format."""
+        """Validate person format, omit person that is not in correct format, don't raise an error."""
+        if v is None:
+            return []
+        validated = []
         for author in v:
-            if (
-                not isinstance(author, str)
-                or " " not in author
-                or not EMailAddress.validate_python(author.split(" ")[-1][1:-1])
-            ):
-                raise ValueError("Invalid email format")
-        return v
+            try:
+                if not (
+                    not isinstance(author, str)
+                    or " " not in author
+                    or not EMailAddress.validate_python(author.split(" ")[-1][1:-1])
+                ):
+                    validated.append(author)
+                else:
+                    logger.warning(
+                        f"Invalid email format for author {author}, omitting."
+                    )
+            except ValidationError:
+                logger.warning(f"Invalid format for author {author}, omitting.")
+        return validated
 
     @field_validator("uuid")
     @classmethod

src/somesy/julia/writer.py

@@ -2,7 +2,7 @@
 
 import logging
 from pathlib import Path
-from typing import Optional
+from typing import List, Optional
 
 import tomlkit
 from rich.pretty import pretty_repr
@@ -58,6 +58,52 @@ def _to_person(person_obj: str) -> Person:
         """Parse name+email string to a Person."""
         return Person.from_name_email_string(person_obj)
 
+    @property
+    def authors(self) -> List[str]:
+        """Get authors from the pyproject.toml file."""
+        # check if authors can be converted to person, only return valid ones
+        authors = self._get_property("authors")
+        if authors is None:
+            return []
+
+        valid_authors = []
+        for author in authors:
+            try:
+                self._to_person(author)
+                valid_authors.append(author)
+            except (ValueError, AttributeError):
+                logger.warning(f"Invalid author format: {author}")
+        return valid_authors
+
+    @authors.setter
+    def authors(self, authors: List[Person]) -> None:
+        """Set the authors of the project."""
+        authors = [self._from_person(c) for c in authors]
+        self._set_property(self._get_key("authors"), authors)
+
+    @property
+    def maintainers(self) -> List[str]:
+        """Get maintainers from the pyproject.toml file."""
+        # check if maintainers can be converted to person, only return valid ones
+        maintainers = self._get_property("maintainers")
+        if maintainers is None:
+            return []
+
+        valid_maintainers = []
+        for maintainer in maintainers:
+            try:
+                self._to_person(maintainer)
+                valid_maintainers.append(maintainer)
+            except (ValueError, AttributeError):
+                logger.warning(f"Invalid maintainer format: {maintainer}")
+        return valid_maintainers
+
+    @maintainers.setter
+    def maintainers(self, maintainers: List[Person]) -> None:
+        """Set the maintainers of the project."""
+        maintainers = [self._from_person(c) for c in maintainers]
+        self._set_property(self._get_key("maintainers"), maintainers)
+
     def sync(self, metadata: ProjectMetadata) -> None:
         """Sync output file with other metadata files."""
         # overridden to not sync fields that are not present in the Project.toml file

tests/output/test_julia_writer.py

@@ -115,3 +115,37 @@ def test_person_merge(request, julia_file, person):
     assert len(pj.authors) == 2
     assert pj.authors[0] == person1c_rep
     assert pj.authors[1] == person3_rep
+
+
+def test_without_email(tmp_path, person):
+    project_toml_str = """
+        name = "test-package"
+        version = "0.1.0"
+        authors = ["Jane Doe"]
+        uuid = "608dde89-f1f1-4a1a-863e-3c5da0c9a9e3"
+    """
+    # save to file
+    project_file = tmp_path / Path("Project.toml")
+    project_file.write_text(project_toml_str)
+
+    # load and sync
+    pj = Julia(project_file)
+
+    assert len(pj.authors) == 0
+
+    pm = ProjectMetadata(
+        name="My awesome project",
+        description="Project description",
+        license=LicenseEnum.MIT,
+        version="0.1.0",
+        people=[
+            person.model_copy(
+                update=dict(author=True, publication_author=True, maintainer=True)
+            )
+        ],
+    )
+
+    pj.sync(pm)
+
+    assert len(pj.authors) == 1
+    assert pj.authors[0] == f"{person.full_name} <{person.email}>"