return None if person conversion fails

Author: mustafasoylu

src/somesy/fortran/writer.py

@@ -90,7 +90,7 @@ def _from_person(person: Person):
         return person.to_name_email_string()
 
     @staticmethod
-    def _to_person(person_obj: Any) -> Person:
+    def _to_person(person_obj: Any) -> Optional[Person]:
         """Cannot convert from free string to person object."""
         try:
             return Person.from_name_email_string(person_obj)

src/somesy/julia/writer.py

@@ -2,7 +2,7 @@
 
 import logging
 from pathlib import Path
-from typing import List, Optional
+from typing import Optional
 
 import tomlkit
 from rich.pretty import pretty_repr
@@ -54,55 +54,13 @@ def _from_person(person: Person):
         return person.to_name_email_string()
 
     @staticmethod
-    def _to_person(person_obj: str) -> Person:
+    def _to_person(person_obj) -> Optional[Person]:
         """Parse name+email string to a Person."""
-        return Person.from_name_email_string(person_obj)
-
-    @property
-    def authors(self) -> List[str]:
-        """Get authors from the pyproject.toml file."""
-        # check if authors can be converted to person, only return valid ones
-        authors = self._get_property("authors")
-        if authors is None:
-            return []
-
-        valid_authors = []
-        for author in authors:
-            try:
-                self._to_person(author)
-                valid_authors.append(author)
-            except (ValueError, AttributeError):
-                logger.warning(f"Invalid author format: {author}")
-        return valid_authors
-
-    @authors.setter
-    def authors(self, authors: List[Person]) -> None:
-        """Set the authors of the project."""
-        authors = [self._from_person(c) for c in authors]
-        self._set_property(self._get_key("authors"), authors)
-
-    @property
-    def maintainers(self) -> List[str]:
-        """Get maintainers from the pyproject.toml file."""
-        # check if maintainers can be converted to person, only return valid ones
-        maintainers = self._get_property("maintainers")
-        if maintainers is None:
-            return []
-
-        valid_maintainers = []
-        for maintainer in maintainers:
-            try:
-                self._to_person(maintainer)
-                valid_maintainers.append(maintainer)
-            except (ValueError, AttributeError):
-                logger.warning(f"Invalid maintainer format: {maintainer}")
-        return valid_maintainers
-
-    @maintainers.setter
-    def maintainers(self, maintainers: List[Person]) -> None:
-        """Set the maintainers of the project."""
-        maintainers = [self._from_person(c) for c in maintainers]
-        self._set_property(self._get_key("maintainers"), maintainers)
+        try:
+            return Person.from_name_email_string(person_obj)
+        except (ValueError, AttributeError):
+            logger.warning(f"Cannot convert {person_obj} to Person object.")
+            return None
 
     def sync(self, metadata: ProjectMetadata) -> None:
         """Sync output file with other metadata files."""

src/somesy/mkdocs/writer.py

@@ -62,13 +62,11 @@ def save(self, path: Optional[Path] = None) -> None:
     @property
     def authors(self):
         """Return the only author from the source file as list."""
-        authors = []
-        try:
-            self._to_person(self._get_property(self._get_key("authors")))
-            authors = [self._get_property(self._get_key("authors"))]
-        except AttributeError:
-            logger.warning("Cannot convert authors to Person object.")
-        return authors
+        authors = self._get_property(self._get_key("authors"))
+        if authors is None or self._to_person(authors) is None:
+            return []
+        else:
+            return [authors]
 
     @authors.setter
     def authors(self, authors: List[Person]) -> None:
@@ -82,9 +80,13 @@ def _from_person(person: Person):
         return person.to_name_email_string()
 
     @staticmethod
-    def _to_person(person: str):
+    def _to_person(person: str) -> Optional[Person]:
         """MkDocs Person is a string with full name."""
-        return Person.from_name_email_string(person)
+        try:
+            return Person.from_name_email_string(person)
+        except (ValueError, AttributeError):
+            logger.warning(f"Cannot convert {person} to Person object.")
+            return None
 
     def sync(self, metadata: ProjectMetadata) -> None:
         """Sync the MkDocs object with the ProjectMetadata object."""

src/somesy/pyproject/writer.py

@@ -96,61 +96,19 @@ def __init__(self, path: Path):
         """
         super().__init__(path, section=["tool", "poetry"], model_cls=PoetryConfig)
 
-    @property
-    def authors(self) -> List[str]:
-        """Get authors from the pyproject.toml file."""
-        # check if authors can be converted to person, only return valid ones
-        authors = self._get_property("authors")
-        if authors is None:
-            return []
-
-        valid_authors = []
-        for author in authors:
-            try:
-                self._to_person(author)
-                valid_authors.append(author)
-            except (ValueError, AttributeError):
-                logger.warning(f"Invalid author format: {author}")
-        return valid_authors
-
-    @authors.setter
-    def authors(self, authors: List[Person]) -> None:
-        """Set the authors of the project."""
-        authors = [self._from_person(c) for c in authors]
-        self._set_property(self._get_key("authors"), authors)
-
-    @property
-    def maintainers(self) -> List[str]:
-        """Get maintainers from the pyproject.toml file."""
-        # check if maintainers can be converted to person, only return valid ones
-        maintainers = self._get_property("maintainers")
-        if maintainers is None:
-            return []
-
-        valid_maintainers = []
-        for maintainer in maintainers:
-            try:
-                self._to_person(maintainer)
-                valid_maintainers.append(maintainer)
-            except (ValueError, AttributeError):
-                logger.warning(f"Invalid maintainer format: {maintainer}")
-        return valid_maintainers
-
-    @maintainers.setter
-    def maintainers(self, maintainers: List[Person]) -> None:
-        """Set the maintainers of the project."""
-        maintainers = [self._from_person(c) for c in maintainers]
-        self._set_property(self._get_key("maintainers"), maintainers)
-
     @staticmethod
     def _from_person(person: Person):
         """Convert project metadata person object to poetry string for person format "full name <email>."""
         return person.to_name_email_string()
 
     @staticmethod
-    def _to_person(person_obj: str) -> Person:
+    def _to_person(person_obj: str) -> Optional[Person]:
         """Parse poetry person string to a Person."""
-        return Person.from_name_email_string(person_obj)
+        try:
+            return Person.from_name_email_string(person_obj)
+        except (ValueError, AttributeError):
+            logger.warning(f"Cannot convert {person_obj} to Person object.")
+            return None
 
 
 class SetupTools(PyprojectCommon):

src/somesy/rust/writer.py

@@ -89,7 +89,7 @@ def _from_person(person: Person):
         return person.to_name_email_string()
 
     @staticmethod
-    def _to_person(person_obj: str) -> Person:
+    def _to_person(person_obj: str) -> Optional[Person]:
         """Parse rust person string to a Person. It has format "full name <email>." but email is optional."""
         try:
             return Person.from_name_email_string(person_obj)