somesy metadata orcid id number is acceptable

Author: mustafasoylu

src/somesy/core/models.py

@@ -560,6 +560,17 @@ class Person(ContributorBaseModel):
 
     # helper methods
 
+    @field_validator("orcid", mode="before")
+    @classmethod
+    def orcid_from_string(cls, orcid: str) -> Optional[HttpUrlStr]:
+        """Convert orcid id string to HttpUrlStr."""
+        # orcid regex without https://orcid.org/ prefix
+        orcid_regex = r"^[0-9]{4}-[0-9]{4}-[0-9]{4}-[0-9]{3}[0-9X]$"
+        if orcid is not None and isinstance(orcid, str):
+            if re.match(orcid_regex, orcid):
+                return f"https://orcid.org/{orcid}"
+        return orcid
+
     @property
     def full_name(self) -> str:
         """Return the full name of the person."""

tests/processing/test_core_models.py

@@ -165,3 +165,20 @@ def test_custom_key_order():
 
     # key order also preserved by copy
     assert p.model_copy()._key_order == p._key_order
+
+
+def test_orcid_from_string():
+    person_dict = {
+        "given-names": "Jane",
+        "family-names": "Doe",
+        "email": "mail@example.com",
+        "orcid": "0000-0003-2637-0432",
+    }
+    orcid_url = "https://orcid.org/0000-0003-2637-0432"
+    p = Person(**person_dict)
+    assert str(p.orcid) == orcid_url
+
+    # with http:// prefix
+    person_dict["orcid"] = orcid_url
+    p = Person(**person_dict)
+    assert str(p.orcid) == orcid_url