From 7527764bd33612da4d4109eb5776509fe694d4ec Mon Sep 17 00:00:00 2001 From: Cassio Rossi Date: Thu, 30 Apr 2026 16:45:40 -0300 Subject: [PATCH] fix(#280): increase cookie expiration from 60s to 24h The 60-second cookie expiration caused the `patr` ad-removal cookie to expire during browsing sessions. Deferred/lazy-loaded ads that fire after the initial page render would no longer see the cookie, causing banners to reappear. 24 hours ensures coverage for the entire session while cookies are still refreshed on every new page load. Co-Authored-By: Claude Opus 4.6 --- .../MacMagazineUILibrary/Webview/Cookies.swift | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/MacMagazine/Features/MacMagazineUILibrary/Sources/MacMagazineUILibrary/Webview/Cookies.swift b/MacMagazine/Features/MacMagazineUILibrary/Sources/MacMagazineUILibrary/Webview/Cookies.swift index 09a1d6c7..0cc400dc 100644 --- a/MacMagazine/Features/MacMagazineUILibrary/Sources/MacMagazineUILibrary/Webview/Cookies.swift +++ b/MacMagazine/Features/MacMagazineUILibrary/Sources/MacMagazineUILibrary/Webview/Cookies.swift @@ -5,6 +5,7 @@ public struct Cookies { static let disqus = "disqus.com" static let mmDomain = "macmagazine.com.br" + private static let cookieExpiration: TimeInterval = 86_400 private static let disqusCookiesKey = "disqus_saved_cookies" @@ -52,7 +53,7 @@ public struct Cookies { .name: "_color_schema", .value: value, .secure: "true", - .expires: NSDate(timeIntervalSinceNow: 60) + .expires: NSDate(timeIntervalSinceNow: cookieExpiration) ]) } @@ -63,7 +64,7 @@ public struct Cookies { .name: "darkmode", .value: value, .secure: "true", - .expires: NSDate(timeIntervalSinceNow: 60) + .expires: NSDate(timeIntervalSinceNow: cookieExpiration) ]) } @@ -74,7 +75,7 @@ public struct Cookies { .name: "fonte", .value: value, .secure: "true", - .expires: NSDate(timeIntervalSinceNow: 60) + .expires: NSDate(timeIntervalSinceNow: cookieExpiration) ]) } @@ -85,7 +86,7 @@ public struct Cookies { .name: "version", .value: value, .secure: "true", - .expires: NSDate(timeIntervalSinceNow: 60) + .expires: NSDate(timeIntervalSinceNow: cookieExpiration) ]) } @@ -96,7 +97,7 @@ public struct Cookies { .name: "patr", .value: value, .secure: "true", - .expires: NSDate(timeIntervalSinceNow: 60) + .expires: NSDate(timeIntervalSinceNow: cookieExpiration) ]) } }