Replace ShowDisabledTooltipExtension with ToolTip.ShowOnDisabled in XAML files

Reduced memory usage from excessive GetVisualDescendant calls previously

Author: ionite34

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
 - Fixed Triton/Sage install option showing for incompatible GPUs
 - Fixed errors from invalid pip specifiers in requirements files
 - Fixed package images sometimes showing as blank due to concurrent image caching. Requests to same image resources are now de-duplicated
+- Reduced memory usage from `ShowDisabledTooltipExtension`
 ### Supporters
 #### Visionaries
 - Big shout-out to our Visionary-tier patrons: Waterclouds, Corey T, bluepopsicle, and Bob S! Your steadfast support keeps Stability Matrix moving forward, and we couldn’t do it without you. 🚀 Thank you!

StabilityMatrix.Avalonia/MarkupExtensions/ShowDisabledTooltipExtension.cs

@@ -11,7 +11,6 @@
     xmlns:fluentAvalonia="clr-namespace:FluentIcons.Avalonia.Fluent;assembly=FluentIcons.Avalonia.Fluent"
     xmlns:input="clr-namespace:FluentAvalonia.UI.Input;assembly=FluentAvalonia"
     xmlns:lang="clr-namespace:StabilityMatrix.Avalonia.Languages"
-    xmlns:markupExtensions="clr-namespace:StabilityMatrix.Avalonia.MarkupExtensions"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
     xmlns:models="clr-namespace:StabilityMatrix.Avalonia.Models"
     d:DataContext="{x:Static designData:DesignData.SelectModelVersionViewModel}"
@@ -303,12 +302,12 @@
 
             <Button
                 Margin="8,0"
-                markupExtensions:ShowDisabledTooltipExtension.ShowOnDisabled="True"
                 Classes="accent"
                 Command="{Binding Import}"
                 Content="{x:Static lang:Resources.Action_Import}"
                 IsEnabled="{Binding IsImportEnabled}"
                 IsVisible="{Binding !SelectedFile.IsInstalled, TargetNullValue=True, FallbackValue=True}"
+                ToolTip.ShowOnDisabled="True"
                 ToolTip.Tip="{Binding ImportTooltip}" />
 
             <Button

StabilityMatrix.Avalonia/Views/Dialogs/SelectModelVersionDialog.axaml

@@ -6,11 +6,9 @@
     xmlns:converters="clr-namespace:StabilityMatrix.Avalonia.Converters"
     xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
     xmlns:designData="clr-namespace:StabilityMatrix.Avalonia.DesignData"
-    xmlns:generic="clr-namespace:System.Collections.Generic;assembly=System.Runtime"
     xmlns:icons="clr-namespace:Projektanker.Icons.Avalonia;assembly=Projektanker.Icons.Avalonia"
     xmlns:input="clr-namespace:FluentAvalonia.UI.Input;assembly=FluentAvalonia"
     xmlns:lang="clr-namespace:StabilityMatrix.Avalonia.Languages"
-    xmlns:markupExtensions="clr-namespace:StabilityMatrix.Avalonia.MarkupExtensions"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
     xmlns:models="clr-namespace:StabilityMatrix.Core.Models;assembly=StabilityMatrix.Core"
     xmlns:packageManager="clr-namespace:StabilityMatrix.Avalonia.ViewModels.PackageManager"
@@ -335,10 +333,10 @@
                                         <Button
                                             Margin="4,4,4,0"
                                             Padding="4"
-                                            markupExtensions:ShowDisabledTooltipExtension.ShowOnDisabled="True"
                                             Classes="borderless-success"
                                             Command="{Binding Update}"
-                                            IsEnabled="{Binding !IsRunning}">
+                                            IsEnabled="{Binding !IsRunning}"
+                                            ToolTip.ShowOnDisabled="True">
                                             <ToolTip.Tip>
                                                 <TextBlock>
                                                     <Run Text="{x:Static lang:Resources.Label_UpdateAvailable}" />

StabilityMatrix.Avalonia/Views/PackageManager/MainPackageManagerView.axaml

@@ -3,21 +3,15 @@
     xmlns="https://github.com/avaloniaui"
     xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
     xmlns:avalonia="clr-namespace:FluentIcons.Avalonia;assembly=FluentIcons.Avalonia"
-    xmlns:behaviors="clr-namespace:StabilityMatrix.Avalonia.Behaviors"
     xmlns:controls="clr-namespace:StabilityMatrix.Avalonia.Controls"
-    xmlns:controls1="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
     xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
     xmlns:database="clr-namespace:StabilityMatrix.Core.Models.Database;assembly=StabilityMatrix.Core"
     xmlns:designData="clr-namespace:StabilityMatrix.Avalonia.DesignData"
     xmlns:dialogs="clr-namespace:StabilityMatrix.Avalonia.Views.Dialogs"
-    xmlns:labs="clr-namespace:Avalonia.Labs.Controls;assembly=Avalonia.Labs.Controls"
     xmlns:lang="clr-namespace:StabilityMatrix.Avalonia.Languages"
-    xmlns:markupExtensions="clr-namespace:StabilityMatrix.Avalonia.MarkupExtensions"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
     xmlns:models="clr-namespace:StabilityMatrix.Core.Models;assembly=StabilityMatrix.Core"
     xmlns:packageManager="clr-namespace:StabilityMatrix.Avalonia.ViewModels.PackageManager"
-    xmlns:python="clr-namespace:StabilityMatrix.Core.Python;assembly=StabilityMatrix.Core"
-    xmlns:system="clr-namespace:System;assembly=System.Runtime"
     d:DataContext="{x:Static designData:DesignData.PackageInstallDetailViewModel}"
     d:DesignHeight="850"
     d:DesignWidth="800"
@@ -68,11 +62,11 @@
                     IsChecked="{Binding !IsReleaseMode, Mode=TwoWay}" />
                 <ToggleButton
                     Grid.Column="1"
-                    markupExtensions:ShowDisabledTooltipExtension.ShowOnDisabled="True"
                     Content="Releases"
                     CornerRadius="0,8,8,0"
                     IsChecked="{Binding IsReleaseMode, Mode=TwoWay}"
                     IsEnabled="{Binding ShowReleaseMode}"
+                    ToolTip.ShowOnDisabled="True"
                     ToolTip.Tip="{Binding ReleaseTooltipText}" />
 
                 <controls:BetterComboBox