Fix model cards to be transient again to not share states

Author: ionite34

StabilityMatrix.Avalonia/ViewModels/Inference/ModelCardViewModel.cs

@@ -20,7 +20,7 @@ namespace StabilityMatrix.Avalonia.ViewModels.Inference;
 
 [View(typeof(ModelCard))]
 [ManagedService]
-[RegisterScoped<ModelCardViewModel>]
+[RegisterTransient<ModelCardViewModel>]
 public partial class ModelCardViewModel(
     IInferenceClientManager clientManager,
     IServiceManager<ViewModelBase> vmFactory,

StabilityMatrix.Avalonia/ViewModels/Inference/PromptCardViewModel.cs

@@ -45,7 +45,7 @@ namespace StabilityMatrix.Avalonia.ViewModels.Inference;
 
 [View(typeof(PromptCard))]
 [ManagedService]
-[RegisterScoped<PromptCardViewModel>]
+[RegisterTransient<PromptCardViewModel>]
 public partial class PromptCardViewModel
     : DisposableLoadableViewModelBase,
         IParametersLoadableState,
@@ -337,15 +337,15 @@ public void ApplyStep(ModuleApplyStepEventArgs e)
                 {
                     Name = $"PositiveCLIP_{modelConnections.Name}",
                     Clip = e.Builder.Connections.Base.Clip!,
-                    Text = e.Builder.Connections.PositivePrompt
+                    Text = e.Builder.Connections.PositivePrompt,
                 }
             );
             var negativeClip = e.Nodes.AddTypedNode(
                 new ComfyNodeBuilder.CLIPTextEncode
                 {
                     Name = $"NegativeCLIP_{modelConnections.Name}",
                     Clip = e.Builder.Connections.Base.Clip!,
-                    Text = e.Builder.Connections.NegativePrompt
+                    Text = e.Builder.Connections.NegativePrompt,
                 }
             );
 
@@ -419,60 +419,60 @@ public async Task<bool> ValidatePrompts()
     private async Task ShowHelpDialog()
     {
         var md = $$"""
-                  ## {{Resources.Label_Emphasis}}
-                  You can also use (`Ctrl+Up`/`Ctrl+Down`) in the editor to adjust the 
-                  weight emphasis of the token under the caret or the currently selected text.
-                  ```prompt
-                  (keyword)
-                  (keyword:1.0)
-                  ```
-                  
-                  ## {{Resources.Label_Deemphasis}}
-                  ```prompt
-                  [keyword]
-                  ```
-                  
-                  ## {{Resources.Label_EmbeddingsOrTextualInversion}}
-                  They may be used in either the positive or negative prompts. 
-                  Essentially they are text presets, so the position where you place them 
-                  could make a difference. 
-                  ```prompt
-                  <embedding:model>
-                  <embedding:model:1.0>
-                  ```
-                  
-                  ## {{Resources.Label_NetworksLoraOrLycoris}}
-                  Unlike embeddings, network tags do not get tokenized to the model, 
-                  so the position in the prompt where you place them does not matter.
-                  ```prompt
-                  <lora:model>
-                  <lora:model:1.0>
-                  <lyco:model>
-                  <lyco:model:1.0>
-                  ```
-                  
-                  ## {{Resources.Label_Comments}}
-                  Inline comments can be marked by a hashtag ' # '. 
-                  All text after a ' # ' on a line will be disregarded during generation.
-                  ```prompt
-                  # comments
-                  a red cat # also comments
-                  detailed
-                  ```
-                  
-                  ## {{Resources.Label_Wildcards}}
-                  Wildcards can be used to select a random value from a list of options.
-                  ```prompt
-                  {red|green|blue} cat
-                  ```
-                  In this example, a color will be randomly chosen at the start of each generation. 
-                  The final output could be "red cat", "green cat", or "blue cat".
-                  
-                  You can also use networks and embeddings in wildcards. For example:
-                  ```prompt
-                  {<lora:model:1>|<embedding:model>} cat
-                  ```
-                  """;
+            ## {{Resources.Label_Emphasis}}
+            You can also use (`Ctrl+Up`/`Ctrl+Down`) in the editor to adjust the 
+            weight emphasis of the token under the caret or the currently selected text.
+            ```prompt
+            (keyword)
+            (keyword:1.0)
+            ```
+
+            ## {{Resources.Label_Deemphasis}}
+            ```prompt
+            [keyword]
+            ```
+
+            ## {{Resources.Label_EmbeddingsOrTextualInversion}}
+            They may be used in either the positive or negative prompts. 
+            Essentially they are text presets, so the position where you place them 
+            could make a difference. 
+            ```prompt
+            <embedding:model>
+            <embedding:model:1.0>
+            ```
+
+            ## {{Resources.Label_NetworksLoraOrLycoris}}
+            Unlike embeddings, network tags do not get tokenized to the model, 
+            so the position in the prompt where you place them does not matter.
+            ```prompt
+            <lora:model>
+            <lora:model:1.0>
+            <lyco:model>
+            <lyco:model:1.0>
+            ```
+
+            ## {{Resources.Label_Comments}}
+            Inline comments can be marked by a hashtag ' # '. 
+            All text after a ' # ' on a line will be disregarded during generation.
+            ```prompt
+            # comments
+            a red cat # also comments
+            detailed
+            ```
+
+            ## {{Resources.Label_Wildcards}}
+            Wildcards can be used to select a random value from a list of options.
+            ```prompt
+            {red|green|blue} cat
+            ```
+            In this example, a color will be randomly chosen at the start of each generation. 
+            The final output could be "red cat", "green cat", or "blue cat".
+
+            You can also use networks and embeddings in wildcards. For example:
+            ```prompt
+            {<lora:model:1>|<embedding:model>} cat
+            ```
+            """;
 
         var dialog = DialogHelper.CreateMarkdownDialog(md, "Prompt Syntax", TextEditorPreset.Prompt);
         dialog.MinDialogWidth = 800;
@@ -531,7 +531,7 @@ private async Task DebugShowTokens()
                 builder.AppendLine($"## Networks ({networks.Count}):");
                 builder.AppendLine("```csharp");
                 builder.AppendLine(
-                    JsonSerializer.Serialize(networks, new JsonSerializerOptions() { WriteIndented = true, })
+                    JsonSerializer.Serialize(networks, new JsonSerializerOptions() { WriteIndented = true })
                 );
                 builder.AppendLine("```");
             }
@@ -622,11 +622,10 @@ private async Task AmplifyPrompt()
             "illustrious" => [ModelTags.Illustrious],
             _ => [],
         };
-        var mode = IsFocused
-            ? PromptExpansionRequestMode.Focused
-            : IsImaginative
-                ? PromptExpansionRequestMode.Imaginative
-                : PromptExpansionRequestMode.Balanced;
+        var mode =
+            IsFocused ? PromptExpansionRequestMode.Focused
+            : IsImaginative ? PromptExpansionRequestMode.Imaginative
+            : PromptExpansionRequestMode.Balanced;
         try
         {
             var expandedPrompt = await promptGenApi.ExpandPrompt(
@@ -636,11 +635,11 @@ private async Task AmplifyPrompt()
                     {
                         PositivePrompt = prompt.ProcessedText ?? prompt.RawText,
                         NegativePrompt = negativePrompt.ProcessedText ?? negativePrompt.RawText,
-                        Model = selectedModel?.Local?.DisplayModelName
+                        Model = selectedModel?.Local?.DisplayModelName,
                     },
                     Model = IsThinkingEnabled ? "PromptV1ThinkingDev" : "PromptV1Dev",
                     Mode = mode,
-                    ModelTags = modelTags
+                    ModelTags = modelTags,
                 }
             );
 
@@ -661,8 +660,8 @@ private async Task AmplifyPrompt()
                         "Rate Limit Reached"
                     );
                     dialog.PrimaryButtonText = "Upgrade";
-                    dialog.PrimaryButtonCommand = new RelayCommand(
-                        () => ProcessRunner.OpenUrl("https://patreon.com/join/StabilityMatrix")
+                    dialog.PrimaryButtonCommand = new RelayCommand(() =>
+                        ProcessRunner.OpenUrl("https://patreon.com/join/StabilityMatrix")
                     );
                     dialog.IsPrimaryButtonEnabled = true;
                     dialog.DefaultButton = ContentDialogButton.Primary;
@@ -753,7 +752,7 @@ public override JsonObject SaveStateToJsonObject()
             {
                 Prompt = PromptDocument.Text,
                 NegativePrompt = NegativePromptDocument.Text,
-                ModulesCardState = ModulesCardViewModel.SaveStateToJsonObject()
+                ModulesCardState = ModulesCardViewModel.SaveStateToJsonObject(),
             }
         );
     }
@@ -785,7 +784,7 @@ public GenerationParameters SaveStateToParameters(GenerationParameters parameter
         return parameters with
         {
             PositivePrompt = PromptDocument.Text,
-            NegativePrompt = NegativePromptDocument.Text
+            NegativePrompt = NegativePromptDocument.Text,
         };
     }
 
@@ -799,7 +798,7 @@ private async Task<bool> ShowLoginDialog()
         dialog.Buttons =
         [
             new TaskDialogButton(Resources.Action_Login, TaskDialogStandardResult.OK),
-            TaskDialogButton.CloseButton
+            TaskDialogButton.CloseButton,
         ];
 
         if (await dialog.ShowAsync(true) is not TaskDialogStandardResult.OK)
@@ -808,7 +807,7 @@ private async Task<bool> ShowLoginDialog()
         var vm = vmFactory.Get<OAuthDeviceAuthViewModel>();
         vm.ChallengeRequest = new OpenIddictClientModels.DeviceChallengeRequest
         {
-            ProviderName = OpenIdClientConstants.LykosAccount.ProviderName
+            ProviderName = OpenIdClientConstants.LykosAccount.ProviderName,
         };
         await vm.ShowDialogAsync();
 

StabilityMatrix.Avalonia/ViewModels/Inference/SamplerCardViewModel.cs

@@ -27,7 +27,7 @@ namespace StabilityMatrix.Avalonia.ViewModels.Inference;
 
 [View(typeof(SamplerCard))]
 [ManagedService]
-[RegisterScoped<SamplerCardViewModel>]
+[RegisterTransient<SamplerCardViewModel>]
 public partial class SamplerCardViewModel : LoadableViewModelBase, IParametersLoadableState, IComfyStep
 {
     private ISettingsManager settingsManager;

StabilityMatrix.Avalonia/ViewModels/Inference/Video/ImgToVidModelCardViewModel.cs

@@ -11,7 +11,7 @@ namespace StabilityMatrix.Avalonia.ViewModels.Inference.Video;
 
 [View(typeof(ModelCard))]
 [ManagedService]
-[RegisterScoped<ImgToVidModelCardViewModel>]
+[RegisterTransient<ImgToVidModelCardViewModel>]
 public class ImgToVidModelCardViewModel : ModelCardViewModel
 {
     public ImgToVidModelCardViewModel(
@@ -30,7 +30,7 @@ public override void ApplyStep(ModuleApplyStepEventArgs e)
             new ComfyNodeBuilder.ImageOnlyCheckpointLoader
             {
                 Name = "ImageOnlyCheckpointLoader",
-                CkptName = SelectedModel?.RelativePath ?? throw new ValidationException("Model not selected")
+                CkptName = SelectedModel?.RelativePath ?? throw new ValidationException("Model not selected"),
             }
         );