Add timeout to MNIST data download#891
Open
massy-o wants to merge 1 commit into
Open
Conversation
massy-o
commented
May 14, 2026
| "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0" | ||
| } | ||
| request_opts = {"headers": headers, "params": {"raw": "true"}} | ||
| request_opts = {"headers": headers, "params": {"raw": "true"}, "timeout": 30} |
Author
There was a problem hiding this comment.
Self-review: The timeout lives in request_opts so the existing requests.get call shape stays the same while the data download no longer waits indefinitely when GitHub stalls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The integration slice downloads sample data from GitHub when the local cache is missing. If the remote request stalls, the test process can hang on the socket indefinitely. A bounded timeout makes failures faster and easier to diagnose.
Testing