Merge pull request #342 from weisJ/ui_fixes

UI fixes

Author: Konloch

src/main/java/the/bytecode/club/bytecodeviewer/BytecodeViewer.java

@@ -84,7 +84,7 @@
  *
  * TODO DarkLAF Specific Bugs:
  *      + Resource List creates swing lag with large project
- *      + JMenuBar can only be displayed on a JFrame, a work around is needed for this
+ *      + JMenuBar can only be displayed on a JFrame, a work around is needed for this (Partially solved)
  *
  * TODO IN-PROGRESS:
  *      + Resource Exporter/Save/Decompile As Zip needs to be rewritten

src/main/java/the/bytecode/club/bytecodeviewer/gui/components/VisibleComponent.java

@@ -3,8 +3,10 @@
 import com.github.weisj.darklaf.icons.ThemedSVGIcon;
 import the.bytecode.club.bytecodeviewer.Configuration;
 import the.bytecode.club.bytecodeviewer.gui.resourceviewer.Workspace;
+import the.bytecode.club.bytecodeviewer.gui.theme.LAFTheme;
 import the.bytecode.club.bytecodeviewer.resources.IconResources;
 
+import javax.swing.BorderFactory;
 import javax.swing.JInternalFrame;
 
 /***************************************************************************
@@ -40,7 +42,16 @@ public VisibleComponent(final String title)
         super(title, false, false, false, false);
         this.setDefaultIcon();
     }
-    
+
+    @Override
+    public void updateUI() {
+        if (Configuration.lafTheme != LAFTheme.SYSTEM)
+            setBorder(BorderFactory.createEmptyBorder());
+        else
+            setBorder(null);
+        super.updateUI();
+    }
+
     public void setDefaultIcon()
     {
         try {

src/main/java/the/bytecode/club/bytecodeviewer/plugin/PluginWriter.java

@@ -6,7 +6,6 @@
 import the.bytecode.club.bytecodeviewer.BytecodeViewer;
 import the.bytecode.club.bytecodeviewer.Configuration;
 import the.bytecode.club.bytecodeviewer.gui.resourceviewer.viewer.ComponentViewer;
-import the.bytecode.club.bytecodeviewer.gui.theme.LAFTheme;
 import the.bytecode.club.bytecodeviewer.resources.IconResources;
 import the.bytecode.club.bytecodeviewer.gui.components.FileChooser;
 import the.bytecode.club.bytecodeviewer.gui.components.SearchableRSyntaxTextArea;
@@ -18,6 +17,7 @@
 import the.bytecode.club.bytecodeviewer.util.SyntaxLanguage;
 
 import javax.swing.*;
+import javax.swing.border.LineBorder;
 import java.awt.*;
 import java.io.File;
 import java.io.IOException;
@@ -123,16 +123,18 @@ public void setVisible(boolean b)
 
 			JPanel p = new JPanel(new BorderLayout());
 			JPanel p2 = new JPanel(new BorderLayout());
-			
 			p.add(p2, BorderLayout.NORTH);
 			p.add(component, BorderLayout.CENTER);
-			
-			if(Configuration.lafTheme == LAFTheme.SYSTEM)
-				p2.add(getJMenuBar(), BorderLayout.CENTER);
-			else //TODO DarkLAF wont display the jMenuBar due to how it handles them, instead display the menu
-				//TODO make the menu interactable and display the menu manually
-				p2.add(getJMenuBar().getMenu(0), BorderLayout.CENTER);
-			
+
+			JMenuBar menuBar = getJMenuBar();
+			// As the Darklaf windows decorations steal the menu bar from the frame
+			// it sets the preferred size to (0,0). Because we want to steal the menu bar ourselves.
+			// we have to revert this change.
+			// Remove when https://github.com/weisJ/darklaf/issues/258 is fixed and available in a
+			// release.
+			menuBar.setPreferredSize(null);
+			p2.add(menuBar, BorderLayout.CENTER);
+
 			ComponentViewer.addComponentAsTab(pluginName, p);
 		}
 		else

src/main/java/the/bytecode/club/bytecodeviewer/translation/components/TranslatedJMenu.java

@@ -44,4 +44,10 @@ public TranslatedJMenu(String text, TranslatedComponents translatedComponents)
 			componentReference.translate();
 		}
 	}
+
+	@Override
+	public boolean isEnabled()
+	{
+		return super.isEnabled() && getMenuComponentCount() > 0;
+	}
 }