depr predictbelief for propagateBelief

Author: dehann

src/Deprecated.jl

@@ -123,7 +123,49 @@ end
 ## Deprecate code below before v0.35
 ##==============================================================================
 
+
 @deprecate _prepCCW(w...;kw...) _createCCW(w...;kw...)
+@deprecate predictbelief(w...;asPartial::Bool=false,kw...)  ((bel,ipc)=getPoints(propagateBelief(w...;asPartial,kw...)), (getPoints(bel),ipc))
+
+# """
+#     $SIGNATURES
+
+# This is an old function name that will be replaced by [`propagateBelief`](@ref).
+# """
+# function predictbelief(
+#   dfg::AbstractDFG,
+#   destvert::DFGVariable,
+#   factors::AbstractVector; #{<:DFGFactor};
+#   asPartial::Bool = false,
+#   kw...,
+# )
+#   #
+#   # new
+#   mkd, ifd = propagateBelief(dfg, destvert, factors; kw...)
+
+#   # legacy interface
+#   return getPoints(mkd, asPartial), ifd
+# end
+
+# function predictbelief(
+#   dfg::AbstractDFG,
+#   destlbl::Symbol,
+#   fctlbls::AbstractVector{Symbol};
+#   kw...,
+# )
+#   return predictbelief(
+#     dfg,
+#     getVariable(dfg, destlbl),
+#     map(x -> getFactor(dfg, x), fctlbls);
+#     kw...,
+#   )
+# end
+# #
+
+# function predictbelief(dfg::AbstractDFG, destlbl::Symbol, ::Colon; kw...)
+#   return predictbelief(dfg, destlbl, getNeighbors(dfg, destlbl); kw...)
+# end
+#
 
 ##==============================================================================
 ## Deprecate code below before v0.34

src/ExportAPI.jl

@@ -240,7 +240,6 @@ export CSMHistory,
   getCliqNumAssocFactorsPerVar,
 
   # user functions
-  predictbelief,
   propagateBelief,
   getCliqMat,
   getCliqAssocMat,

src/services/GraphInit.jl

@@ -363,13 +363,14 @@ end
 function initVariable!(
   dfg::AbstractDFG,
   label::Symbol,
-  usefcts::Vector{Symbol},
+  usefcts::AbstractVector{Symbol},
   solveKey::Symbol = :default;
   N::Int = getSolverParams(dfg).N,
   kwargs...,
 )
   #
-  pts = predictbelief(dfg, label, usefcts; solveKey = solveKey)[1]
+  pts = propagateBelief(dfg, label, usefcts; solveKey = solveKey)[1]
+  # pts = predictbelief(dfg, label, usefcts; solveKey = solveKey)[1]
   vert = getVariable(dfg, label)
   Xpre = manikde!(getManifold(getVariableType(vert)), pts)
   return initVariable!(vert, Xpre, solveKey; N, kwargs...)

src/services/GraphProductOperations.jl

@@ -59,33 +59,13 @@ function propagateBelief(
   return mkd, ipc
 end
 
-"""
-    $SIGNATURES
-
-This is an old function name that will be replaced by [`propagateBelief`](@ref).
-"""
-function predictbelief(
-  dfg::AbstractDFG,
-  destvert::DFGVariable,
-  factors::AbstractVector; #{<:DFGFactor};
-  asPartial::Bool = false,
-  kw...,
-)
-  #
-  # new
-  mkd, ifd = propagateBelief(dfg, destvert, factors; kw...)
-
-  # legacy interface
-  return getPoints(mkd, asPartial), ifd
-end
-
-function predictbelief(
+function propagateBelief(
   dfg::AbstractDFG,
   destlbl::Symbol,
   fctlbls::AbstractVector{Symbol};
   kw...,
 )
-  return predictbelief(
+  return propagateBelief(
     dfg,
     getVariable(dfg, destlbl),
     map(x -> getFactor(dfg, x), fctlbls);
@@ -94,10 +74,9 @@ function predictbelief(
 end
 #
 
-function predictbelief(dfg::AbstractDFG, destlbl::Symbol, ::Colon; kw...)
-  return predictbelief(dfg, destlbl, getNeighbors(dfg, destlbl); kw...)
-end
-#
+propagateBelief(dfg::AbstractDFG, destlbl::Symbol, ::Colon; kw...) = return propagateBelief(dfg, destlbl, getNeighbors(dfg, destlbl); kw...)
+
+
 
 """
     $(SIGNATURES)