fix createVarValsAll on deserialize

Author: dehann

Project.toml

@@ -48,7 +48,7 @@ TimeZones = "f269a46b-ccf7-5d73-abea-4c690281aa53"
 UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 
 [compat]
-ApproxManifoldProducts = "0.6.3"
+ApproxManifoldProducts = "0.6.3, 0.7"
 BSON = "0.2, 0.3"
 Combinatorics = "1.0"
 DataStructures = "0.16, 0.17, 0.18"

src/services/CalcFactor.jl

@@ -241,12 +241,23 @@ function _createVarValsAll(
 )
   #
   # Note, NamedTuple once upon a time created way too much recompile load on repeat solves, #1564
-  varValsAll = map(var_i->getVal(var_i; solveKey), tuple(variables...))
-
-  for (i,vv) in enumerate(varValsAll)
-    @assert pointer(vv) == pointer(getVal(variables[i]; solveKey)) "Developer check that ccw.varValsAll pointers go to same memory as getVal(variable)"
+  # FIXME ON FIRE issue on deserialization
+  valsAll = []
+
+  # when deserializing a factor, a new ccw gets created but the variables may not yet have VND entries
+  for var_i in variables
+    push!(
+      valsAll,
+      if haskey(getSolverDataDict(var_i), solveKey)
+        getVal(var_i; solveKey)
+      else
+        Vector{typeof(getPointDefault(getVariableType(var_i)))}()
+      end
+    )
   end
 
+  varValsAll = tuple(valsAll...)
+
   # how many points
   LEN = length.(varValsAll)
   maxlen = maximum(LEN)