Skip to content

Commit e4d943c

Browse files
committed
Fix erf by adding IrrationalConstants
1 parent 6b0b0e9 commit e4d943c

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

Project.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ version = "0.2.1"
77
ChainRules = "082447d4-558c-5d27-93f4-14fc19e9eca2"
88
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
99
ChainRulesOverloadGeneration = "f51149dc-2911-5acf-81fc-2076a2a81d4f"
10+
IrrationalConstants = "92d709cd-6900-40b7-9082-c6be49f344b6"
1011
SliceMap = "82cb661a-3f19-5665-9e27-df437c7e54c8"
1112
SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
1213
SymbolicUtils = "d1185830-fcd6-423d-90d6-eec64667417b"
@@ -18,6 +19,7 @@ ChainRulesCore = "1"
1819
ChainRulesOverloadGeneration = "0.1"
1920
SliceMap = "0.2"
2021
SpecialFunctions = "2"
22+
IrrationalConstants = "0.2"
2123
SymbolicUtils = "1"
2224
Zygote = "0.6.55"
2325
julia = "1.6"

src/codegen.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using ChainRulesCore
22
using SpecialFunctions
3+
using IrrationalConstants: sqrtπ
34
using SymbolicUtils, SymbolicUtils.Code
45
using SymbolicUtils: BasicSymbolic, Pow
56

@@ -26,7 +27,7 @@ using SymbolicUtils: BasicSymbolic, Pow
2627
@scalar_rule asech(x::BasicSymbolic) inv(x * -sqrt(1 - x^2))
2728
@scalar_rule asinh(x::BasicSymbolic) inv(sqrt(x^2 + 1))
2829
@scalar_rule atanh(x::BasicSymbolic) inv(1 - x^2)
29-
@scalar_rule erf(x::BasicSymbolic) exp(-x^2)*(2 / sqrt(pi))
30+
@scalar_rule erf(x::BasicSymbolic) exp(-x^2) * 2/sqrtπ
3031

3132
dummy = (NoTangent(), 1)
3233
@syms t₁

0 commit comments

Comments
 (0)