Improve coverage

Author: tansongchen

src/chainrules.jl

@@ -1,5 +1,4 @@
 import ChainRulesCore: rrule, RuleConfig
-ChainRulesCore.debug_mode() = true
 
 @opt_out rrule(::Any, ::TaylorScalar)
 @opt_out rrule(::Any, ::TaylorScalar, ::TaylorScalar)

src/primitive.jl

@@ -50,15 +50,14 @@ for func in (:sin, :cos)
             c1 = cos(v[1])
         end
         for i in 2:N
-            ex = quote
-                $ex
-                $(Symbol('s', i)) = +($([:($(binomial(i - 2, j - 1)) * $(Symbol('c', j)) *
-                                           v[$i + 1 - $j])
-                                         for j in 1:(i - 1)]...))
-                $(Symbol('c', i)) = +($([:($(-binomial(i - 2, j - 1)) * $(Symbol('s', j)) *
-                                           v[$i + 1 - $j])
-                                         for j in 1:(i - 1)]...))
-            end
+            ex = :($ex;
+                   $(Symbol('s', i)) = +($([:($(binomial(i - 2, j - 1)) *
+                                              $(Symbol('c', j)) *
+                                              v[$i + 1 - $j]) for j in 1:(i - 1)]...)))
+            ex = :($ex;
+                   $(Symbol('c', i)) = +($([:($(-binomial(i - 2, j - 1)) *
+                                              $(Symbol('s', j)) *
+                                              v[$i + 1 - $j]) for j in 1:(i - 1)]...)))
         end
         if $(QuoteNode(func)) == :sin
             ex = :($ex; TaylorScalar($([Symbol('s', i) for i in 1:N]...)))

src/scalar.jl

@@ -68,7 +68,3 @@ function promote_rule(::Type{TaylorScalar{T, N}},
                       ::Type{S}) where {T <: Number, S <: Number, N}
     TaylorScalar{promote_type(T, S), N}
 end
-function promote_rule(::Type{TaylorScalar{T, N}},
-                      ::Type{TaylorScalar{S, N}}) where {T <: Number, S <: Number, N}
-    TaylorScalar{promote_type(T, S), N}
-end

test/primitive.jl

@@ -7,12 +7,15 @@ using FiniteDifferences
     end
     for f in (+, -, <, <=, >, >=, ==), order in (2,)
         @test derivative(x -> f(x, another_number), some_number, order) ≈ 0.0
+        @test derivative(x -> f(another_number, x), some_number, order) ≈ 0.0
+        @test derivative(x -> f(x, x), some_number, order) ≈ 0.0
     end
 end
 
 @testset "Unary functions" begin
     some_number = 3.7
-    for f in (exp, expm1, exp2, exp10, sin, cos, sqrt, cbrt, inv), order in (1, 4)
+    for f in (x -> exp(x^2), expm1, exp2, exp10, x -> sin(x^2), x -> cos(x^2), sqrt, cbrt,
+              inv), order in (1, 4)
         fdm = central_fdm(12, order)
         @test derivative(f, some_number, order)≈fdm(f, some_number) rtol=1e-6
     end