feat(karthik_model): neural network training on NBA CSV data#13
Open
Kravi001 wants to merge 1 commit into
Open
feat(karthik_model): neural network training on NBA CSV data#13Kravi001 wants to merge 1 commit into
Kravi001 wants to merge 1 commit into
Conversation
22dc60f to
1cbbb6d
Compare
JonathanPLev
requested changes
Feb 10, 2026
| # ------------------------- | ||
| X_temp, X_test, y_temp, y_test = train_test_split(X, y, test_size=0.15, random_state=42) | ||
| X_train, X_val, y_train, y_val = train_test_split(X_temp, y_temp, test_size=0.176, random_state=42) | ||
|
|
Owner
There was a problem hiding this comment.
you are definitely having leaking data here because you are having random split
JonathanPLev
requested changes
Feb 10, 2026
| # ------------------------- | ||
| # SPLIT | ||
| # ------------------------- | ||
| X_temp, X_test, y_temp, y_test = train_test_split(X, y, test_size=0.15, random_state=42) |
Owner
There was a problem hiding this comment.
youre also not dropping any of the lines that leak data to the outcome. like youre not removing any stats like points or anything thats current game.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
karthik_model.pyinsrc/mini_nn/to train a neural network on NBA CSV data.Data/PlayerStatistics.csv, preprocesses features, handles NaNs, and manages class imbalance.Why I changed it
How did I test it