Add filenames_template for use in timeseries plots#253
Merged
Conversation
karpob
requested review from
CoryMartin-NOAA,
EdwardSafford-NOAA and
kevindougherty-noaa
Collaborator
|
@karpob changes seem fine to me, not sure why the unit tests are failing though... |
Collaborator
Author
|
@CoryMartin-NOAA Yeah, I'm not sure either. I ran them locally without an issue. |
Collaborator
|
The GitHub tests are fragile, we can merge as-is and deal with later |
CoryMartin-NOAA
approved these changes
Feb 12, 2026
Collaborator
Author
|
@CoryMartin-NOAA Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add capability to use filenames_template to timeseries plots.
Dependencies
None
Impact
Changes a test to use timeseries template in place of explicitly using filenames.