From 618be819503e8f8513d6b420e5cfb688c080f6d5 Mon Sep 17 00:00:00 2001 From: KhawarMehfooz Date: Fri, 31 Jul 2026 11:40:36 +0500 Subject: [PATCH] fix: require PHP ^8.4 to match CI and mb_str_functions usage (#696) composer.json declared PHP ^8.3, but pint.json enables mb_str_functions (mb_trim/mb_ltrim/mb_rtrim, added in PHP 8.4) and every CI workflow pins php-version 8.4. Installing on real PHP 8.3.x would fatal on any of the existing mb_trim() call sites. Bumps the composer constraint and README requirements to 8.4 to match what the project actually needs. --- README.md | 4 ++-- composer.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 6a549e7e..f8fd84f7 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # InvoicePlane v2 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT) -[![PHP Version](https://img.shields.io/badge/PHP-8.3%2B-blue.svg)](https://php.net) +[![PHP Version](https://img.shields.io/badge/PHP-8.4%2B-blue.svg)](https://php.net) [![Laravel Version](https://img.shields.io/badge/Laravel-13%2B-red.svg)](https://laravel.com) [![Filament Version](https://img.shields.io/badge/Filament-5.x-orange.svg)](https://filamentphp.com) @@ -44,7 +44,7 @@ ## 📦 Requirements -- **PHP** 8.3 or higher +- **PHP** 8.4 or higher - **Composer** 2.x - **Node.js** 20+ and Yarn - **Database** MariaDB 10.11+ (recommended), MySQL 8.0+, or SQLite (dev only) diff --git a/composer.json b/composer.json index 9ca877c6..2e6a7b7b 100644 --- a/composer.json +++ b/composer.json @@ -17,7 +17,7 @@ "minimum-stability": "dev", "prefer-stable": true, "require": { - "php": "^8.3", + "php": "^8.4", "awcodes/mason": "^3.1", "doctrine/dbal": ">=4.4", "dompdf/dompdf": "^3.1",