Empty the typing contract's exemption list but for one module

Forty-one modules in one sweep, and the list is now a single line:
`gui/remote_desktop/webrtc_panel.py`, blocked on the split its size cap
already owes it (recorded in Progress.md).

Several were annotations that were simply wrong about what the code
returns, and fixing them is what let the callers stop working around it:

* `screenshot()` said `-> List[int]` while it returns the captured BGR
  frame. Every caller that read `.shape` off it was reading through a
  lie; `screen_record` was the one mypy caught.
* `visual_match._nms` was typed for `Match` and reused from
  `rotated_match`, `edge_match` and `color_match` with their own record
  types. It takes a `TypeVar` bound to a read-only Protocol of what it
  actually reads — position, size, score — which is also why the bound
  had to be properties: the records are frozen dataclasses, and a
  Protocol attribute demands a writable one.
* `logical_frame`'s injectable grabber was typed `Callable[..., Any]`
  while its own docstring says "ImageGrab-shaped object", so `.grab()`
  on it was an error.

Four fix a `None` the code could really see: `humanize.motion` and
`watcher` unpacked `get_mouse_position()` (the Windows backend returns
None on a locked desktop), `dag.runner` opened a node's `action_file`
without checking a node had one, and `color_match` divided a `None`
accumulator when handed no channels.

`secret_store._require_unlocked` now returns the `(fernet, vault)` pair
it checks, which removed three `type: ignore`s that existed only because
the check and the use were separate statements.

Two more cv2 names — `VideoWriter_fourcc` and `ORB_create` — join
`MSER_create` as present at runtime but absent from the shipped stub.

Author: JE-Chen

architecture_explore.md

@@ -55,12 +55,16 @@ def preprocess_read_str_execute_action(execute_str: str):
             "--execute_str",
             type=str, help="execute json str"
         )
-        args = parser.parse_args()
-        args = vars(args)
-        for key, value in args.items():
-            if value is not None:
-                argparse_event_dict.get(key)(value)
-        if all(value is None for value in args.values()):
+        parsed = vars(parser.parse_args())
+        for key, value in parsed.items():
+            if value is None:
+                continue
+            handler = argparse_event_dict.get(key)
+            if handler is None:
+                raise AutoControlArgparseException(
+                    argparse_get_wrong_data_error_message)
+            handler(value)
+        if all(value is None for value in parsed.values()):
             raise AutoControlArgparseException(argparse_get_wrong_data_error_message)
     except AutoControlArgparseException as error:
         autocontrol_logger.error("argparse failure: %r", error)

je_auto_control/__main__.py

@@ -26,7 +26,7 @@
 import sys
 import threading
 import time
-from typing import Dict, List, Optional, Sequence
+from typing import Callable, Dict, List, Optional, Sequence
 
 from je_auto_control.utils.exception.exceptions import (
     AutoControlActionException,
@@ -215,7 +215,7 @@ def cmd_start_rest(args: argparse.Namespace) -> int:
     return 0
 
 
-def _run_until_signal(shutdown: callable) -> None:
+def _run_until_signal(shutdown: Callable[[], None]) -> None:
     stopping = {"flag": False}
 
     def _handler(_signum, _frame):

je_auto_control/cli.py

@@ -58,6 +58,7 @@ def act_with_mode(action: Callable[[List[int]], Any],
     point = list(report.point) if report.point is not None else None
     base = {"mode": mode, "actionable": report.actionable,
             "reason": report.reason, "point": point}
-    if mode == "trial" or not report.actionable:
+    target = report.point
+    if mode == "trial" or not report.actionable or target is None:
         return {**base, "acted": False, "result": None}
-    return {**base, "acted": True, "result": action(report.point)}
+    return {**base, "acted": True, "result": action(target)}

je_auto_control/utils/act_modes/act_modes.py

@@ -77,7 +77,8 @@ def _draw_arrow(draw: ImageDraw.ImageDraw, ann: Dict[str, Any]) -> None:
 
 
 def _draw_text(draw: ImageDraw.ImageDraw, ann: Dict[str, Any]) -> None:
-    pos = tuple(int(v) for v in ann["position"])
+    raw = ann["position"]
+    pos = (float(raw[0]), float(raw[1]))
     draw.text(pos, str(ann.get("text", "")), fill=_color(ann.get("color")))
 
 
@@ -101,7 +102,7 @@ def annotate_screenshot(source: ImageSource,
     draw = ImageDraw.Draw(base)
     dispatch = {"box": _draw_box, "arrow": _draw_arrow, "text": _draw_text}
     for ann in annotations:
-        handler = dispatch.get(ann.get("type"))
+        handler = dispatch.get(str(ann.get("type", "")))
         if handler is not None:
             handler(draw, ann)
     out = Path(output_path)

je_auto_control/utils/annotate/annotate.py

@@ -35,7 +35,7 @@ def rank_changes(scored_boxes: Sequence[Any], *,
     is ``True`` when the score is at or above ``threshold``.
     """
     limit = float(threshold)
-    result = [
+    result: List[Dict[str, Any]] = [
         {"box": [int(value) for value in box],
          "score": round(float(score), 4),
          "changed": float(score) >= limit}

je_auto_control/utils/change_localize/change_localize.py

@@ -42,13 +42,14 @@ def _action_to_call(action: Sequence, event_dict: dict, public: set) -> str:
     name = action[0]
     params = action[1] if len(action) == 2 else None
     func = event_dict.get(name)
-    direct = func is not None and getattr(func, "__name__", "") in public
+    public_name = getattr(func, "__name__", "") if func is not None else ""
+    direct = public_name in public
     if direct and (params is None or isinstance(params, dict)):
         if params:
             kwargs = ", ".join(
                 f"{key}={value!r}" for key, value in params.items())
-            return f"ac.{func.__name__}({kwargs})"
-        return f"ac.{func.__name__}()"
+            return f"ac.{public_name}({kwargs})"
+        return f"ac.{public_name}()"
     return f"ac.execute_action({[list(action)]!r})"
 
 

je_auto_control/utils/codegen/codegen.py

@@ -50,6 +50,8 @@ def _score_map(template_hsv, haystack_hsv, channels: Sequence[str]):
                                    template_hsv[:, :, index], cv2.TM_SQDIFF_NORMED)
         result = np.nan_to_num(result, nan=1.0, posinf=1.0)
         accumulator = result if accumulator is None else accumulator + result
+    if accumulator is None:
+        raise ValueError("match_color needs at least one channel")
     return 1.0 - accumulator / len(channels)
 
 

je_auto_control/utils/color_match/color_match.py

@@ -78,7 +78,8 @@ def region_color_stats(source: ImageSource,
     """
     image = _load_rgb(source)
     if region is not None:
-        image = image.crop(tuple(int(v) for v in region))
+        left, top, right, bottom = (int(v) for v in region)
+        image = image.crop((left, top, right, bottom))
     image.thumbnail((128, 128))
     pixels: List[RGB] = list(image.getdata())
     count = len(pixels)

je_auto_control/utils/color_stats/color_stats.py

@@ -96,7 +96,8 @@ def merge_buckets(local: ConfigBucket,
             local_entry = local_sec.get(entry_id)
             remote_entry = remote_sec.get(entry_id)
             if local_entry is None:
-                merged_section[entry_id] = remote_entry
+                if remote_entry is not None:
+                    merged_section[entry_id] = remote_entry
                 continue
             if remote_entry is None:
                 merged_section[entry_id] = local_entry