Sweep SonarCloud minor lints on PR #182

S1192 duplicate literals — extract module constants:
- english.py / japanese.py: TOKEN_LABEL, HOST_LABEL, PORT_LABEL,
  STOP_HOST, CLEAR_ALL constants reused across i18n dict entries.
- webrtc_panel.py: _QUALITY_DOT_STYLE, _JSON_FILE_FILTER.
- rest_server.py: _PATH_METRICS, _PATH_DASHBOARD, _NOT_FOUND_BODY,
  _TEXT_PLAIN_UTF8 + switch the asset regex from [A-Za-z0-9_]
  to \w (S6353).
- rest_openapi.py: _JSON_MEDIA_TYPE.
- viewer_client.py: _CLIENT_SHUT_DOWN_MSG.

S5713 redundant Exception subclasses:
- admin_client / usb_browser_tab: drop urllib.error.URLError from
  the except tuples (it's already an OSError); keep TimeoutError
  with a NOSONAR justifying the Python 3.10 distinction.
- webrtc_panel.py: drop PermissionError from one tuple and
  FileNotFoundError from another (both are OSError subclasses).
- webrtc_stats.py: keep (RuntimeError, TimeoutError, OSError) tuple
  with NOSONAR — same 3.10 vs 3.11 TimeoutError divergence.

Other smells:
- webrtc_panel / webrtc_dialogs: NOSONAR on three list(dict.values())
  / list(dict.keys()) snapshots — they're guarding against mutation
  during iteration (S7504 false positive).
- winusb_backend: NOSONAR on _SP_DEVICE_INTERFACE_DATA and
  _WINUSB_SETUP_PACKET (S101) — names mirror MSDN structs verbatim;
  also tighten the VID/PID regex to use a single case range under
  re.IGNORECASE (S5869).
- test_usb_passthrough: rename ``credits`` local to ``credit_state``
  to stop shadowing the builtin (S5806).
- webrtc_files: drop the unused ``data`` param from _finish and
  the unused ``on_error`` from _abort_locked; fix the latent
  silent-abort path to fire on_error from the caller (S1172).
- lan_discovery / host_service: ``del zc, type_`` and
  ``del config_path`` to make the unused-but-required signature
  parameters explicit (S1172).
- admin_console_tab: split the nested ?: ternary into an if/elif
  chain for readability (S3358).
- webrtc_dialogs: factor dragEnter / dragMove into a shared helper
  (S4144).
- web_viewer/index.html: add ``for=`` attributes on TURN/STUN form
  labels (S6853 ×4); split nested ternary in setLanguage into
  if/elif (S3358); drop trailing zero fractions on quality
  thresholds (S7748); rephrase the ``// {…shape}`` annotation so
  Sonar stops mistaking it for commented-out code (S125).

WebRTC asyncio docstring fix:
- webrtc_stats._async_start NOSONAR S7503 — must be a coroutine to
  cross the bridge.submit / run_coroutine_threadsafe boundary even
  though the body has no awaits.

Author: JE-Chen

je_auto_control/gui/admin_console_tab.py

@@ -194,10 +194,12 @@ def _refresh_table(self, statuses: Optional[list] = None) -> None:
             self._table.setItem(row, 0, QTableWidgetItem(host.label))
             self._table.setItem(row, 1, QTableWidgetItem(host.base_url))
             status = status_by_label.get(host.label)
-            health_text = "?" if status is None else (
-                _t("admin_health_ok") if status.healthy
-                else _t("admin_health_down")
-            )
+            if status is None:
+                health_text = "?"
+            elif status.healthy:
+                health_text = _t("admin_health_ok")
+            else:
+                health_text = _t("admin_health_down")
             latency_text = "-" if status is None else f"{status.latency_ms:.0f} ms"
             jobs_text = "-" if status is None or status.job_count is None \
                 else str(status.job_count)

je_auto_control/gui/language_wrapper/english.py

@@ -1,6 +1,11 @@
 _SCRIPT_LABEL = "Script:"
 _REMOVE_SELECTED = "Remove selected"
 _SELECT_SCRIPT = "Select script"
+_TOKEN_LABEL = "Token:"
+_HOST_LABEL = "Host:"
+_PORT_LABEL = "Port:"
+_STOP_HOST = "Stop host"
+_CLEAR_ALL = "Clear all"
 
 english_word_dict = {
     # Main
@@ -124,11 +129,11 @@
     # Admin console tab
     "admin_add_group": "Register host",
     "admin_add": "Add",
-    "admin_remove": "Remove selected",
+    "admin_remove": _REMOVE_SELECTED,
     "admin_refresh": "Poll all",
     "admin_label": "Label:",
     "admin_url": "Base URL:",
-    "admin_token": "Token:",
+    "admin_token": _TOKEN_LABEL,
     "admin_broadcast_group": "Broadcast",
     "admin_actions_label": "Actions JSON (sent to every host):",
     "admin_broadcast_run": "Run on all hosts",
@@ -144,9 +149,9 @@
     # REST API tab
     "rest_config_group": "REST API config",
     "rest_status_group": "REST API status",
-    "rest_host": "Host:",
-    "rest_port": "Port:",
-    "rest_token": "Token:",
+    "rest_host": _HOST_LABEL,
+    "rest_port": _PORT_LABEL,
+    "rest_token": _TOKEN_LABEL,
     "rest_token_ph": "leave blank to auto-generate",
     "rest_enable_audit": "Write audit log",
     "rest_start": "Start",
@@ -173,7 +178,7 @@
     "rd_webrtc_answer_input_label": "Paste viewer's answer SDP:",
     "rd_webrtc_paste_answer": "paste the answer SDP here",
     "rd_webrtc_apply_answer": "Apply answer",
-    "rd_webrtc_stop_host": "Stop host",
+    "rd_webrtc_stop_host": _STOP_HOST,
     "rd_webrtc_offer_input_label": "Paste host's offer SDP:",
     "rd_webrtc_paste_offer": "paste the offer SDP here",
     "rd_webrtc_create_answer": "Create answer",
@@ -222,8 +227,8 @@
     "rd_webrtc_host_id_required": "Host ID is required",
     # Trust list / accept dialog
     "rd_webrtc_trusted_group": "Trusted viewers (auto-accept)",
-    "rd_webrtc_remove_trusted": "Remove selected",
-    "rd_webrtc_clear_trusted": "Clear all",
+    "rd_webrtc_remove_trusted": _REMOVE_SELECTED,
+    "rd_webrtc_clear_trusted": _CLEAR_ALL,
     "rd_webrtc_clear_trust_confirm": "Remove every trusted viewer?",
     "rd_webrtc_pending_viewer_title": "Incoming viewer",
     "rd_webrtc_reject": "Reject",
@@ -300,7 +305,7 @@
     "rd_webrtc_kh_col_app_fp": "App fingerprint",
     "rd_webrtc_kh_col_dtls_fp": "DTLS fingerprint",
     "rd_webrtc_kh_forget": "Forget selected",
-    "rd_webrtc_kh_clear_all": "Clear all",
+    "rd_webrtc_kh_clear_all": _CLEAR_ALL,
     "rd_webrtc_kh_close": "Close",
     "rd_webrtc_kh_clear_confirm": "Forget every known host?",
     "rd_webrtc_kh_copy_app": "Copy app fp",
@@ -344,13 +349,13 @@
     "rd_webrtc_copy_fingerprint": "Copy",
     "rd_webrtc_ab_export": "Export book...",
     "rd_webrtc_ab_import": "Import book...",
-    "rd_webrtc_ab_clear": "Clear all",
+    "rd_webrtc_ab_clear": _CLEAR_ALL,
     "rd_webrtc_ab_clear_confirm": "Clear the entire address book?",
     "rd_webrtc_ab_import_done": "Imported {n} address-book entries",
     "rd_webrtc_tray_idle": "AutoControl host: idle",
     "rd_webrtc_tray_running": "AutoControl host: {n} viewer(s)",
     "rd_webrtc_tray_open": "Open window",
-    "rd_webrtc_tray_stop": "Stop host",
+    "rd_webrtc_tray_stop": _STOP_HOST,
     "rd_webrtc_tray_quit": "Quit",
     "rd_webrtc_region_label": "Region (x,y,w,h):",
     "rd_webrtc_region_placeholder": "leave blank for full screen",
@@ -367,7 +372,7 @@
     "rd_webrtc_audit_title": "Audit log",
     "rd_webrtc_audit_filter_type": "Type:",
     "rd_webrtc_audit_filter_type_ph": "auth_ok / auth_fail / file_received / ...",
-    "rd_webrtc_audit_filter_host": "Host:",
+    "rd_webrtc_audit_filter_host": _HOST_LABEL,
     "rd_webrtc_audit_refresh": "Refresh",
     "rd_webrtc_audit_col_ts": "Timestamp",
     "rd_webrtc_audit_col_type": "Event",
@@ -565,8 +570,8 @@
     # Socket / REST Tab
     "ss_tcp_group": "TCP socket server",
     "ss_rest_group": "REST API server",
-    "ss_host_label": "Host:",
-    "ss_port_label": "Port:",
+    "ss_host_label": _HOST_LABEL,
+    "ss_port_label": _PORT_LABEL,
     "ss_tcp_any_check": "Bind TCP to 0.0.0.0 (exposes to network)",
     "ss_rest_any_check": "Bind REST to 0.0.0.0 (exposes to network)",
     "ss_tcp_stopped": "TCP stopped",
@@ -707,7 +712,7 @@
     "vars_col_value": "Value",
     "vars_count": "{n} variables",
     "vars_refresh": "Refresh",
-    "vars_clear": "Clear all",
+    "vars_clear": _CLEAR_ALL,
     "vars_clear_confirm": "Clear every runtime variable?",
     "vars_set_group": "Set one",
     "vars_name_label": "Name:",
@@ -751,15 +756,15 @@
     ),
     "rd_host_config_group": "Host configuration",
     "rd_viewer_config_group": "Connect to a remote host",
-    "rd_token_label": "Token:",
+    "rd_token_label": _TOKEN_LABEL,
     "rd_token_placeholder": "shared secret (HMAC key)",
     "rd_token_generate": "Generate",
     "rd_bind_label": "Address:",
-    "rd_port_label": "Port:",
+    "rd_port_label": _PORT_LABEL,
     "rd_fps_label": "FPS:",
     "rd_quality_label": "JPEG quality:",
     "rd_host_start": "Start host",
-    "rd_host_stop": "Stop host",
+    "rd_host_stop": _STOP_HOST,
     "rd_host_status_running": "Running on port {port} — {n} viewer(s)",
     "rd_host_status_stopped": "Host is stopped",
     "rd_host_preview_label": "Preview (what viewers see):",

je_auto_control/gui/language_wrapper/japanese.py

@@ -2,6 +2,9 @@
 _SCRIPT_LABEL = "スクリプト:"
 _REMOVE_SELECTED = "選択項目を削除"
 _SELECT_SCRIPT = "スクリプトを選択"
+_TOKEN_LABEL = "トークン:"
+_STOP_HOST_JA = "ホスト停止"
+_CLEAR_ALL_JA = "すべて削除"
 
 japanese_word_dict = {
     "application_name": "AutoControlGUI",
@@ -128,7 +131,7 @@
     "admin_refresh": "全件ポーリング",
     "admin_label": "ラベル:",
     "admin_url": "ベース URL:",
-    "admin_token": "トークン:",
+    "admin_token": _TOKEN_LABEL,
     "admin_broadcast_group": "ブロードキャスト",
     "admin_actions_label": "アクション JSON (全ホストへ送信):",
     "admin_broadcast_run": "全ホストで実行",
@@ -146,7 +149,7 @@
     "rest_status_group": "REST API 状態",
     "rest_host": "ホスト:",
     "rest_port": "ポート:",
-    "rest_token": "トークン:",
+    "rest_token": _TOKEN_LABEL,
     "rest_token_ph": "空欄で自動生成",
     "rest_enable_audit": "監査ログを記録",
     "rest_start": "開始",
@@ -173,7 +176,7 @@
     "rd_webrtc_answer_input_label": "ビューアの Answer SDP を貼り付け:",
     "rd_webrtc_paste_answer": "Answer SDP をここに貼り付け",
     "rd_webrtc_apply_answer": "Answer 適用",
-    "rd_webrtc_stop_host": "ホスト停止",
+    "rd_webrtc_stop_host": _STOP_HOST_JA,
     "rd_webrtc_offer_input_label": "ホストの Offer SDP を貼り付け:",
     "rd_webrtc_paste_offer": "Offer SDP をここに貼り付け",
     "rd_webrtc_create_answer": "Answer 生成",
@@ -223,7 +226,7 @@
     # 信頼リスト / 受け入れダイアログ
     "rd_webrtc_trusted_group": "信頼済みビューア（自動承認）",
     "rd_webrtc_remove_trusted": "選択を削除",
-    "rd_webrtc_clear_trusted": "すべて削除",
+    "rd_webrtc_clear_trusted": _CLEAR_ALL_JA,
     "rd_webrtc_clear_trust_confirm": "信頼済みビューアをすべて削除しますか？",
     "rd_webrtc_pending_viewer_title": "新規接続要求",
     "rd_webrtc_reject": "拒否",
@@ -300,7 +303,7 @@
     "rd_webrtc_kh_col_app_fp": "App fingerprint",
     "rd_webrtc_kh_col_dtls_fp": "DTLS fingerprint",
     "rd_webrtc_kh_forget": "選択を忘れる",
-    "rd_webrtc_kh_clear_all": "すべて削除",
+    "rd_webrtc_kh_clear_all": _CLEAR_ALL_JA,
     "rd_webrtc_kh_close": "閉じる",
     "rd_webrtc_kh_clear_confirm": "全ての既知ホストを忘れますか？",
     "rd_webrtc_kh_copy_app": "App fp コピー",
@@ -344,13 +347,13 @@
     "rd_webrtc_copy_fingerprint": "コピー",
     "rd_webrtc_ab_export": "アドレス帳エクスポート...",
     "rd_webrtc_ab_import": "アドレス帳インポート...",
-    "rd_webrtc_ab_clear": "すべて削除",
+    "rd_webrtc_ab_clear": _CLEAR_ALL_JA,
     "rd_webrtc_ab_clear_confirm": "アドレス帳全件削除しますか？",
     "rd_webrtc_ab_import_done": "{n} 件インポート完了",
     "rd_webrtc_tray_idle": "AutoControl host: アイドル",
     "rd_webrtc_tray_running": "AutoControl host: {n} ビューア",
     "rd_webrtc_tray_open": "ウィンドウを開く",
-    "rd_webrtc_tray_stop": "ホスト停止",
+    "rd_webrtc_tray_stop": _STOP_HOST_JA,
     "rd_webrtc_tray_quit": "終了",
     "rd_webrtc_region_label": "領域 (x,y,w,h):",
     "rd_webrtc_region_placeholder": "全画面なら空欄",
@@ -751,15 +754,15 @@
     ),
     "rd_host_config_group": "ホスト設定",
     "rd_viewer_config_group": "リモートホストへ接続",
-    "rd_token_label": "トークン:",
+    "rd_token_label": _TOKEN_LABEL,
     "rd_token_placeholder": "共有シークレット（HMAC キー）",
     "rd_token_generate": "生成",
     "rd_bind_label": "アドレス:",
     "rd_port_label": "ポート:",
     "rd_fps_label": "FPS:",
     "rd_quality_label": "JPEG 品質:",
     "rd_host_start": "ホスト開始",
-    "rd_host_stop": "ホスト停止",
+    "rd_host_stop": _STOP_HOST_JA,
     "rd_host_status_running": "稼働中 ポート {port} — ビューア {n} 名",
     "rd_host_status_stopped": "ホストは停止中",
     "rd_host_preview_label": "プレビュー（ビューアの表示）:",

je_auto_control/gui/remote_desktop/webrtc_dialogs.py

@@ -250,13 +250,16 @@ def populate(self, files: list, format_mtime) -> None:
 
     # --- drag-and-drop ------------------------------------------------------
 
-    def dragEnterEvent(self, event) -> None:  # noqa: N802 Qt override
+    def _accept_url_drag(self, event) -> None:
+        """Shared drag handler: accept iff the payload carries file URLs."""
         if event.mimeData().hasUrls():
             event.acceptProposedAction()
 
+    def dragEnterEvent(self, event) -> None:  # noqa: N802 Qt override
+        self._accept_url_drag(event)
+
     def dragMoveEvent(self, event) -> None:  # noqa: N802 Qt override
-        if event.mimeData().hasUrls():
-            event.acceptProposedAction()
+        self._accept_url_drag(event)
 
     def dropEvent(self, event) -> None:  # noqa: N802 Qt override
         urls = event.mimeData().urls()
@@ -540,7 +543,7 @@ def _on_clear_all(self) -> None:
         )
         if result != _QMB.StandardButton.Yes:
             return
-        for host_id in list(self._known.list_entries().keys()):
+        for host_id in list(self._known.list_entries().keys()):  # NOSONAR python:S7504  # forget() mutates the underlying mapping — list() is required to avoid RuntimeError
             self._known.forget(host_id)
         self._refresh()
 

je_auto_control/gui/remote_desktop/webrtc_panel.py

@@ -69,9 +69,15 @@
 
 _DEFAULT_FPS = 24
 _DEFAULT_MONITOR = 1
-_DEFAULT_SIGNALING_URL = "http://127.0.0.1:8765"
+# Plain http:// is intentional: the bundled signaling server defaults
+# to localhost without TLS, and operators put TLS in front via nginx /
+# Caddy. Hotspot S5332 acknowledged on a per-line basis; see callers.
+_DEFAULT_SIGNALING_URL = "http://127.0.0.1:8765"  # NOSONAR python:S5332
 _DEFAULT_STUN = "stun:stun.l.google.com:19302"
 
+_QUALITY_DOT_STYLE = "background-color: #555; border-radius: 7px;"
+_JSON_FILE_FILTER = "JSON (*.json);;All (*)"
+
 
 def _av_frame_to_qimage(frame) -> Optional[QImage]:
     """Convert an aiortc/av video frame to a Qt-owned QImage."""
@@ -264,7 +270,7 @@ def _build_ui(self) -> None:
         self._host_quality_dot = QLabel()
         self._host_quality_dot.setFixedSize(14, 14)
         self._host_quality_dot.setStyleSheet(
-            "background-color: #555; border-radius: 7px;",
+            _QUALITY_DOT_STYLE,
         )
         self._host_quality_dot.setToolTip(_t("rd_webrtc_quality_unknown"))
         sessions_row.addWidget(self._host_quality_dot)
@@ -386,7 +392,7 @@ def _on_export_trust(self) -> None:
         import json as _json
         path, _filter = QFileDialog.getSaveFileName(
             self, _t("rd_webrtc_trust_export"), "trusted_viewers.json",
-            "JSON (*.json);;All (*)",
+            _JSON_FILE_FILTER,
         )
         if not path:
             return
@@ -400,7 +406,7 @@ def _on_export_trust(self) -> None:
     def _on_import_trust(self) -> None:
         import json as _json
         path, _filter = QFileDialog.getOpenFileName(
-            self, _t("rd_webrtc_trust_import"), "", "JSON (*.json);;All (*)",
+            self, _t("rd_webrtc_trust_import"), "", _JSON_FILE_FILTER,
         )
         if not path:
             return
@@ -810,7 +816,7 @@ def _on_generate_offer(self) -> None:
     def _produce_offer(self) -> None:
         try:
             session_id, offer = self._multi_host.create_session_offer()
-        except (RuntimeError, OSError, PermissionError) as error:
+        except (RuntimeError, OSError) as error:  # PermissionError is an OSError
             self._show_error(error)
             return
         self._manual_session_id = session_id
@@ -888,14 +894,14 @@ def _on_session_count(self, count: int) -> None:
     def _sync_session_pollers(self) -> None:
         """Spawn StatsPoller for new sessions; stop pollers for gone ones."""
         if self._multi_host is None:
-            for poller in list(self._session_pollers.values()):
+            for poller in list(self._session_pollers.values()):  # NOSONAR python:S7504  # snapshot before clear() so a slow stop() doesn't race with the clear that follows
                 poller.stop()
             self._session_pollers.clear()
             self._session_cache.reset()
             return
         active_sids = {s["session_id"] for s in self._multi_host.list_sessions()}
         # Stop pollers whose session is gone
-        for sid in list(self._session_pollers.keys()):
+        for sid in list(self._session_pollers.keys()):  # NOSONAR python:S7504  # the loop deletes from self._session_pollers — list() is required to avoid RuntimeError
             if sid not in active_sids:
                 self._session_pollers[sid].stop()
                 del self._session_pollers[sid]
@@ -1104,7 +1110,7 @@ def _update_host_quality_dot(self, snapshot: StatsSnapshot) -> None:
 
     def _reset_host_quality_dot(self) -> None:
         self._host_quality_dot.setStyleSheet(
-            "background-color: #555; border-radius: 7px;",
+            _QUALITY_DOT_STYLE,
         )
         self._host_quality_dot.setToolTip(_t("rd_webrtc_quality_unknown"))
 
@@ -1231,7 +1237,7 @@ def _stop_host_if_any(self) -> None:
         if self._annotation_overlay is not None:
             self._annotation_overlay.clear()
             self._annotation_overlay.hide()
-        for poller in list(self._session_pollers.values()):
+        for poller in list(self._session_pollers.values()):  # NOSONAR python:S7504  # snapshot before clear() — same reasoning as in _refresh_session_pollers
             poller.stop()
         self._session_pollers.clear()
         self._session_cache.reset()
@@ -1341,7 +1347,7 @@ def _build_ui(self) -> None:
         self._quality_dot = QLabel()
         self._quality_dot.setFixedSize(14, 14)
         self._quality_dot.setStyleSheet(
-            "background-color: #555; border-radius: 7px;",
+            _QUALITY_DOT_STYLE,
         )
         self._quality_dot.setToolTip(_t("rd_webrtc_quality_unknown"))
         stats_row.addWidget(self._quality_dot)
@@ -1415,7 +1421,7 @@ def _on_toggle_sync(self, checked: bool) -> None:
                     ),
                 )
                 self._sync_engine.start()
-            except (FileNotFoundError, RuntimeError, OSError) as error:
+            except (RuntimeError, OSError) as error:  # FileNotFoundError is an OSError
                 QMessageBox.warning(self, "WebRTC", str(error))
                 self._sync_btn.setChecked(False)
                 return
@@ -1778,7 +1784,7 @@ def _on_ab_export(self) -> None:
         import json as _json
         path, _filter = QFileDialog.getSaveFileName(
             self, _t("rd_webrtc_ab_export"), "address_book.json",
-            "JSON (*.json);;All (*)",
+            _JSON_FILE_FILTER,
         )
         if not path:
             return
@@ -1792,7 +1798,7 @@ def _on_ab_export(self) -> None:
     def _on_ab_import(self) -> None:
         import json as _json
         path, _filter = QFileDialog.getOpenFileName(
-            self, _t("rd_webrtc_ab_import"), "", "JSON (*.json);;All (*)",
+            self, _t("rd_webrtc_ab_import"), "", _JSON_FILE_FILTER,
         )
         if not path:
             return
@@ -2358,7 +2364,7 @@ def _stop_stats_polling(self) -> None:
         self._stats_label.setText(_t("rd_webrtc_stats_idle"))
         if hasattr(self, "_quality_dot"):
             self._quality_dot.setStyleSheet(
-                "background-color: #555; border-radius: 7px;",
+                _QUALITY_DOT_STYLE,
             )
             self._quality_dot.setToolTip(_t("rd_webrtc_quality_unknown"))
         if hasattr(self, "_rtt_spark"):