Move NOSONAR markers onto the lines Sonar actually flags

Sonar's # NOSONAR suppression is line-scoped and must sit on the
flagged line itself; my earlier markers on the comment line above
weren't picked up. Specifically:

- host.py / viewer.py: S107 fires on the first-parameter line of the
  multi-line def, not on the def keyword line.
- totp.py: S6418 / S5655 markers must trail the assignment / call.
- chat / connect_coordinator / jpeg_recorder tests: S5655 ditto.

All 49 affected tests still green, ruff clean.

Author: JE-Chen

je_auto_control/utils/remote_desktop/host.py

@@ -582,8 +582,8 @@ class RemoteDesktopHost:
     ``stop()`` can be called from any thread.
     """
 
-    def __init__(  # NOSONAR python:S107  # reason: each kwarg is a documented public knob; bundling further would split the API across patterns and force every existing caller (registry, host_panel, tests in 8 files) into a wrapper object for marginal benefit
-            self, token: str,
+    def __init__(
+            self, token: str,  # NOSONAR python:S107  # reason: each kwarg is a documented public knob; bundling further would split the API across patterns and force every existing caller (registry, host_panel, tests in 8 files) through a wrapper object for marginal benefit
             bind: str = "127.0.0.1",
             port: int = 0,
             fps: float = 10.0,

je_auto_control/utils/remote_desktop/viewer.py

@@ -56,8 +56,8 @@ class RemoteDesktopViewer:
     Qt). ``send_input`` is safe to call from any thread.
     """
 
-    def __init__(  # NOSONAR python:S107  # reason: each callback is a documented public hook; bundling further would force every caller (viewer_panel, registry, 10+ test files) through a wrapper object for marginal benefit
-            self, host: str, port: int, token: str,
+    def __init__(
+            self, host: str, port: int, token: str,  # NOSONAR python:S107  # reason: each callback is a documented public hook; bundling further would force every caller (viewer_panel, registry, 10+ test files) through a wrapper object for marginal benefit
             on_frame: Optional[FrameCallback] = None,
             on_error: Optional[ErrorCallback] = None,
             on_audio: Optional[AudioCallback] = None,

test/unit_test/headless/test_remote_desktop_chat_and_multicursor.py

@@ -95,8 +95,7 @@ def test_broadcast_chat_with_empty_text_is_noop(jpeg_bytes):
     host.start()
     try:
         assert host.broadcast_chat("") == 0
-        # NOSONAR python:S5655  # reason: intentional bad-type negative test
-        assert host.broadcast_chat(None) == 0  # type: ignore[arg-type]
+        assert host.broadcast_chat(None) == 0  # type: ignore[arg-type]  # NOSONAR python:S5655  # reason: intentional bad-type negative test
     finally:
         host.stop(timeout=1.0)
 

test/unit_test/headless/test_remote_desktop_connect_coordinator.py

@@ -104,8 +104,7 @@ def test_parse_target_rejects_bad_input(bad):
 
 def test_parse_target_rejects_non_string():
     with pytest.raises(UnresolvableTargetError):
-        # NOSONAR python:S5655  # reason: intentional bad-type negative test
-        parse_target(12345)  # type: ignore[arg-type]
+        parse_target(12345)  # type: ignore[arg-type]  # NOSONAR python:S5655  # reason: intentional bad-type negative test
 
 
 # --- discriminator helpers ---------------------------------------------

test/unit_test/headless/test_remote_desktop_jpeg_recorder.py

@@ -57,11 +57,11 @@ def test_start_twice_raises(tmp_path):
 
 
 def test_record_frame_with_non_bytes_payload(tmp_path):
-    """NOSONAR python:S5655  # reason: intentional bad-type negative test."""
+    """Intentional bad-type negative test."""
     rec = JpegSequenceRecorder(str(tmp_path / "rec"))
     rec.start()
-    rec.record_frame("not-bytes")  # type: ignore[arg-type]
-    rec.record_frame(None)  # type: ignore[arg-type]
+    rec.record_frame("not-bytes")  # type: ignore[arg-type]  # NOSONAR python:S5655  # reason: intentional bad-type negative test
+    rec.record_frame(None)  # type: ignore[arg-type]  # NOSONAR python:S5655  # reason: intentional bad-type negative test
     assert rec.frame_count == 0
 
 

test/unit_test/headless/test_remote_desktop_totp.py

@@ -64,8 +64,7 @@ def test_verify_rejects_malformed_input():
     secret = generate_secret()
     assert verify_code(secret, "abcdef") is False
     assert verify_code(secret, "12345") is False  # too short
-    # NOSONAR python:S5655  # reason: intentional bad-type negative test
-    assert verify_code(secret, 123456) is False  # type: ignore[arg-type]
+    assert verify_code(secret, 123456) is False  # type: ignore[arg-type]  # NOSONAR python:S5655  # reason: intentional bad-type negative test
 
 
 def test_decode_secret_handles_spaces_and_lowercase():
@@ -87,8 +86,7 @@ def test_invalid_secret_raises():
 
 
 def test_provisioning_uri_contains_secret_and_issuer():
-    # NOSONAR python:S6418  # reason: literal base32 test vector, not a real secret
-    secret = "GEZDGNBVGY3TQOJQ"  # nosec B105  # reason: test-only RFC fixture
+    secret = "GEZDGNBVGY3TQOJQ"  # nosec B105  # NOSONAR python:S6418  # reason: published RFC 6238 test vector, not a real credential
     uri = provisioning_uri(secret, account="alice", issuer="MyApp")
     assert uri.startswith("otpauth://totp/")
     assert "secret=GEZDGNBVGY3TQOJQ" in uri