Skip to content

Commit d10b6ee

Browse files
committed
Enhance: Add bundle generation check in release workflow and simplify reconciliation comments in OvercommitClass controller
1 parent ba8257b commit d10b6ee

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ jobs:
2424
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
2525
with:
2626
fetch-depth: 0
27+
- name: Check bundle generation 🧪
28+
run: |
29+
make bundle
30+
git diff --ignore-matching-lines='.*createdAt:.*' --exit-code
31+
2732
- name: 📝 Load Operator version
2833
id: version
2934
run: |

internal/controller/overcommitclass/overcommitclass_controller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ func (r *OvercommitClassReconciler) Reconcile(ctx context.Context, req ctrl.Requ
158158
certificate := resources.CreateCertificate(overcommitClass.Name, *service)
159159
webhookConfig := resources.CreateMutatingWebhookConfiguration(*overcommitClass, *service, *certificate, label)
160160

161-
// Reconcile Deployment with improved logic
161+
// Reconcile Deployment
162162
_, err = controllerutil.CreateOrUpdate(ctx, r.Client, deployment, func() error {
163163
// Regenerate the desired deployment spec
164164
updatedDeployment := resources.CreateDeployment(*overcommitClass)
@@ -214,7 +214,7 @@ func (r *OvercommitClassReconciler) Reconcile(ctx context.Context, req ctrl.Requ
214214
return ctrl.Result{}, err
215215
}
216216

217-
// Reconcile Service with improved logic
217+
// Reconcile Service
218218
_, err = controllerutil.CreateOrUpdate(ctx, r.Client, service, func() error {
219219
// Regenerate the desired service spec
220220
updatedService := resources.CreateService(overcommitClass.Name)
@@ -272,7 +272,7 @@ func (r *OvercommitClassReconciler) Reconcile(ctx context.Context, req ctrl.Requ
272272
return ctrl.Result{}, err
273273
}
274274

275-
// Reconcile Certificate with improved logic
275+
// Reconcile Certificate
276276
_, err = controllerutil.CreateOrUpdate(ctx, r.Client, certificate, func() error {
277277
// Regenerate the desired certificate spec
278278
updatedCertificate := resources.CreateCertificate(overcommitClass.Name, *service)
@@ -331,7 +331,7 @@ func (r *OvercommitClassReconciler) Reconcile(ctx context.Context, req ctrl.Requ
331331
return ctrl.Result{}, err
332332
}
333333

334-
// Reconcile MutatingWebhookConfiguration with improved logic
334+
// Reconcile MutatingWebhookConfiguration
335335
_, err = controllerutil.CreateOrUpdate(ctx, r.Client, webhookConfig, func() error {
336336
// Regenerate the desired webhook configuration
337337
updatedWebhookConfig := resources.CreateMutatingWebhookConfiguration(*overcommitClass, *service, *certificate, label)

0 commit comments

Comments
 (0)