refactor: propagate context instead of using context.Background/TODO

- Accept context parameter in Overcommit and OvercommitOnResize
  functions, propagated from the webhook admission handler
- Accept context in GetDefaultSpec and GetPodServiceAccount instead
  of creating context.Background()/context.TODO() internally
- Enables proper cancellation, timeouts, and distributed tracing
  through the full call chain

Author: enriqueavindi

cmd/main.go

@@ -150,7 +150,7 @@ func main() {
 			os.Exit(1)
 		}
 
-		serviceAccountName, err := utils.GetPodServiceAccount(mgr.GetAPIReader())
+		serviceAccountName, err := utils.GetPodServiceAccount(ctx, mgr.GetAPIReader())
 		if err != nil {
 			setupLog.Error(err, "unable to get pod service account")
 			os.Exit(1)

internal/utils/getOvercommitClass.go

@@ -45,14 +45,14 @@ func GetOvercommitClassSpec(ctx context.Context, name string, k8sClient client.C
 	return &overcommitClass.Spec, nil
 }
 
-func GetDefaultSpec(k8sClient client.Client) (*overcommit.OvercommitClassSpec, error) {
+func GetDefaultSpec(ctx context.Context, k8sClient client.Client) (*overcommit.OvercommitClassSpec, error) {
 	if k8sClient == nil {
 		return nil, errors.New("client parameter cannot be nil")
 	}
 
 	// List all OvercommitClass
 	var overcommitClasses overcommit.OvercommitClassList
-	if err := k8sClient.List(context.Background(), &overcommitClasses); err != nil {
+	if err := k8sClient.List(ctx, &overcommitClasses); err != nil {
 		return nil, fmt.Errorf("error listing OvercommitClass: %w", err)
 	}
 

internal/utils/getOvercommitClass_test.go

@@ -82,7 +82,7 @@ var _ = Describe("GetDefaultSpec", func() {
 
 	It("should retrieve the default OvercommitClassSpec correctly", func() {
 		// Try the GetDefaultSpec function
-		spec, err := GetDefaultSpec(k8sClient)
+		spec, err := GetDefaultSpec(context.Background(), k8sClient)
 		Expect(err).NotTo(HaveOccurred(), "Failed to get default OvercommitClassSpec")
 		Expect(spec).NotTo(BeNil(), "Spec should not be nil")
 		Expect(spec.IsDefault).To(BeTrue(), "Spec.IsDefault should be true")

internal/utils/getPodDetails.go

@@ -58,7 +58,7 @@ func GetPodImageDetails(ctx context.Context, client client.Reader) (string, stri
 	return "", "", "", fmt.Errorf("no containers found in pod")
 }
 
-func GetPodServiceAccount(client client.Reader) (string, error) {
+func GetPodServiceAccount(ctx context.Context, client client.Reader) (string, error) {
 	podName := os.Getenv("POD_NAME")
 	podNamespace := os.Getenv("POD_NAMESPACE")
 
@@ -67,7 +67,7 @@ func GetPodServiceAccount(client client.Reader) (string, error) {
 	}
 
 	pod := &corev1.Pod{}
-	err := client.Get(context.TODO(), types.NamespacedName{
+	err := client.Get(ctx, types.NamespacedName{
 		Name:      podName,
 		Namespace: podNamespace,
 	}, pod)

internal/webhook/v1alphav1/mutating/pod_webhook.go

@@ -51,11 +51,11 @@ func (d *PodCustomDefaulter) Default(ctx context.Context, obj runtime.Object) er
 	}
 
 	if isResize {
-		overcommit.OvercommitOnResize(pod, d.Recorder, d.Client)
+		overcommit.OvercommitOnResize(ctx, pod, d.Recorder, d.Client)
 		return nil
 	}
 
-	overcommit.Overcommit(pod, d.Recorder, d.Client)
+	overcommit.Overcommit(ctx, pod, d.Recorder, d.Client)
 	return nil
 }
 

pkg/overcommit/calculate_values_from_labels.go

@@ -40,7 +40,7 @@ func getNamespaceOvercommit(ctx context.Context, pod *corev1.Pod, client client.
 	}
 
 	podlog.Info("Overcommit class not found in the namespace, using the default", "namespace", ns.Name)
-	defaultClass, err := utils.GetDefaultSpec(client)
+	defaultClass, err := utils.GetDefaultSpec(ctx, client)
 	if err != nil {
 		podlog.Error(err, "Error getting the default overcommit class")
 		return 1.0, 1.0

pkg/overcommit/make_overcommit.go

@@ -51,8 +51,7 @@ func mutateContainers(containers []corev1.Container, pod *corev1.Pod, cpuValue f
 	}
 }
 
-func Overcommit(pod *corev1.Pod, recorder record.EventRecorder, client client.Client) {
-	ctx := context.Background()
+func Overcommit(ctx context.Context, pod *corev1.Pod, recorder record.EventRecorder, client client.Client) {
 	className := os.Getenv("OVERCOMMIT_CLASS_NAME")
 
 	metrics.K8sOvercommitOperatorPodsRequestedTotal.WithLabelValues(className).Inc()
@@ -91,8 +90,7 @@ func Overcommit(pod *corev1.Pod, recorder record.EventRecorder, client client.Cl
 	)
 }
 
-func OvercommitOnResize(pod *corev1.Pod, recorder record.EventRecorder, client client.Client) {
-	ctx := context.Background()
+func OvercommitOnResize(ctx context.Context, pod *corev1.Pod, recorder record.EventRecorder, client client.Client) {
 	className := os.Getenv("OVERCOMMIT_CLASS_NAME")
 
 	metrics.K8sOvercommitOperatorPodsRequestedTotal.WithLabelValues(className).Inc()