diff --git a/Project.toml b/Project.toml index 06a40c2..021aa0c 100644 --- a/Project.toml +++ b/Project.toml @@ -1,20 +1,22 @@ name = "FactoredMatrices" uuid = "13d07ad6-c0d4-11e8-35b1-91a532e61cc8" -authors = ["Tim Holy "] version = "1.0.0" +authors = ["Tim Holy "] [deps] LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" [compat] Aqua = "0.8" +ExplicitImports = "1" LinearAlgebra = "1" Test = "1" julia = "1.10" [extras] Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" +ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" [targets] -test = ["Aqua", "Test"] +test = ["Aqua", "ExplicitImports", "Test"] diff --git a/src/FactoredMatrices.jl b/src/FactoredMatrices.jl index c6f6ab8..a80b2e3 100644 --- a/src/FactoredMatrices.jl +++ b/src/FactoredMatrices.jl @@ -1,6 +1,6 @@ module FactoredMatrices -using LinearAlgebra +using LinearAlgebra: LinearAlgebra, Adjoint, Factorization, Transpose import Base: *, Array, Matrix, size, length, similar, ==, hash, adjoint, transpose import LinearAlgebra: mul!, dot @@ -30,15 +30,6 @@ end FactoredMatrix{T}(U::AbstractMatrix{T}, V::AbstractMatrix{T}) where {T} = FactoredMatrix{T, typeof(U), typeof(V)}(U, V) FactoredMatrix(U::AbstractMatrix{T}, V::AbstractMatrix{T}) where {T} = FactoredMatrix{T}(U, V) -function FactoredMatrix(U::Matrix{T}, V::Matrix{T}, ::Integer) where {T} - Base.depwarn( - "FactoredMatrix(U, V, j) is deprecated; use FactoredMatrix(U, V) and " * - "create a Workspace(fm, j) for allocation-free mul!", - :FactoredMatrix - ) - return FactoredMatrix{T}(U, V) -end - """ Workspace{T}(k::Int, p::Int) Workspace(A::FactoredMatrix, p::Int) diff --git a/test/REQUIRE b/test/REQUIRE deleted file mode 100644 index 3ccc0bb..0000000 --- a/test/REQUIRE +++ /dev/null @@ -1,5 +0,0 @@ -HyperDualNumbers -Distances -ForwardDiff -JLD2 -Unitful diff --git a/test/runtests.jl b/test/runtests.jl index f09c55c..40b921b 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,6 +1,7 @@ using Test, LinearAlgebra using FactoredMatrices using Aqua +using ExplicitImports myrand(::Type{T}, m, n) where {T <: Real} = rand(T, m, n) myrand(::Type{Complex{T}}, m, n) where {T <: Real} = rand(T, m, n) + im * rand(T, m, n) @@ -35,6 +36,10 @@ end end end +@testset "ExplicitImports" begin + @test ExplicitImports.check_no_implicit_imports(FactoredMatrices) === nothing +end + @testset "FactoredMatrices" begin for T in (Float32, Float64, ComplexF32, ComplexF64) # Mf: 15×10 (U: 15×3, V: 3×10)