From 2a4b925f189d2723ad6c4f1659b5dad529828651 Mon Sep 17 00:00:00 2001 From: "guys-inc-ops[bot]" <321481384+guys-inc-ops[bot]@users.noreply.github.com> Date: Thu, 27 Aug 2026 15:49:20 +0000 Subject: [PATCH] Release as 3.5.0: 3.4.10 through 3.4.14 are already tagged The version chosen in #37 cannot be used. This repository inherited 301 release-* tags from the lineage it forked from, running up to release-3.4.14-linux1, and release-3.4.10-linux1 has existed since 2025-02-09. Release tags are immutable under the org ruleset, so none of 3.4.10 to 3.4.14 can be reused. I checked dpkg and semver ordering when picking 3.4.10 and did not check whether the tag was free. 3.5.0 rather than 3.4.15. Both are free and both are clean in dpkg and semver ordering, but either one decouples this fork's numbering from upstream's - the difference is only whether that is visible. A minor bump says so, where skipping five patch numbers looks like an accident. It is also the more honest description of what is in here: seven major versions of Electron and a rewritten sign-in are not a patch release. 3.4.9-linux2 was the truthful alternative and was rejected on cost. It is a semver prerelease, so it sorts *below* 3.4.9 - release-notes.ts builds a SemVer from the running version and filters for releases newer than it, which would make the app offer 3.4.9's notes as "what's new" to someone who had just upgraded past it. Release notes re-rendered for 3.5.0-linux1: 0 unparsed entries. --- app/package.json | 2 +- changelog.json | 2 +- docs/known-issues.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/package.json b/app/package.json index 3bdbd3ac7b..5003c45649 100644 --- a/app/package.json +++ b/app/package.json @@ -3,7 +3,7 @@ "productName": "GitHub Desktop", "bundleID": "com.github.GitHubClient", "companyName": "GitHub, Inc.", - "version": "3.4.10", + "version": "3.5.0", "main": "./main.js", "repository": { "type": "git", diff --git a/changelog.json b/changelog.json index a0f24edb6e..8df950fe3b 100644 --- a/changelog.json +++ b/changelog.json @@ -1,6 +1,6 @@ { "releases": { - "3.4.10": [ + "3.5.0": [ "[Added] Sign in to GitHub.com using the OAuth device flow: Desktop shows a one-time code to enter in your browser, instead of handing off through a redirect", "[Fixed] The published packages no longer contain an OAuth client secret. Desktop authenticates as a public client, so no secret is built into the application", "[Improved] Upgrade Electron to v39.8.10, from v32.1.2, picking up seven major versions of Chromium security fixes", diff --git a/docs/known-issues.md b/docs/known-issues.md index fec5577099..36366eda01 100644 --- a/docs/known-issues.md +++ b/docs/known-issues.md @@ -283,7 +283,7 @@ covers what you are granting. ### Signing in asks for a code instead of opening a sign-in page -This is expected from 3.4.10 onwards, and is not an error. +This is expected from 3.5.0 onwards, and is not an error. Desktop now signs in using the OAuth **device flow**: it shows a one-time code, you open the link in a browser, enter the code, and approve the request. The