Remaining Actionable Items
These items from the initial code review still need to be addressed.
Validation Improvements (CEL Rules)
| # |
Issue |
Location |
Notes |
| 1 |
EmailHookSpec.URI not validated |
supabaseproject_types.go |
Add CEL rule: URI required when enabled=true |
| 2 |
AuthProvidersSpec.SecretRef not validated |
supabaseproject_types.go |
Add CEL rule: secretRef required when Google or Apple enabled |
Resolved Items
- ✅ PG_META_PORT defined twice - Fixed
- ✅ JWT expiration mismatch - Fixed (comment clarifies API keys=5yr, access tokens=ExpirationSeconds)
- ✅ Early return in reconcileSecrets - Fixed
- ✅ Kong default tag mismatch - Fixed (aligned to 2.8.1)
- ✅ Duplicate init container builders - Removed (operator reconciliation handles ordering)
Kept As-Is (Future Feature Placeholders)
These are intentionally unused - placeholders for future features:
- SMTPSpec - future SMTP support
- BackupSpec fields (Schedule, RetentionPolicy, EndpointURL) - future backup config
- AdditionalExtensions - future custom extensions
Remaining Actionable Items
These items from the initial code review still need to be addressed.
Validation Improvements (CEL Rules)
enabled=trueResolved Items
Kept As-Is (Future Feature Placeholders)
These are intentionally unused - placeholders for future features: