Skip to content

Commit fa95ecc

Browse files
committed
fix(iso): install genisoimage for isoinfo in smoke test
test-image.sh now verifies the arm64 GRUB boot chain with isoinfo (RockRidge listing); the smoke-test runners did not have isoinfo installed, so the step failed with exit 127. Add genisoimage to the QEMU/ISO tooling step for both architectures.
1 parent 09398ec commit fa95ecc

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/iso.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,10 @@ jobs:
211211
sudo apt-get update
212212
if [[ "${{ matrix.arch }}" == "amd64" ]]; then
213213
sudo apt-get install -y --no-install-recommends \
214-
qemu-system-x86 qemu-utils ovmf xorriso squashfs-tools
214+
qemu-system-x86 qemu-utils ovmf xorriso squashfs-tools genisoimage
215215
else
216216
sudo apt-get install -y --no-install-recommends \
217-
qemu-system-arm qemu-utils qemu-efi-aarch64 xorriso squashfs-tools
217+
qemu-system-arm qemu-utils qemu-efi-aarch64 xorriso squashfs-tools genisoimage
218218
fi
219219
220220
- name: Validate ISO image contents

eng/iso/test-image.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ esac
1616
readonly SQUASHFS_PATH="${WORK_DIR}/filesystem.squashfs"
1717
readonly EXTRACTED_ROOT="${WORK_DIR}/root"
1818

19-
for command in xorriso unsquashfs sha256sum file; do
19+
for command in xorriso unsquashfs sha256sum file isoinfo; do
2020
if ! command -v "${command}" >/dev/null 2>&1; then
21-
echo "error: ${command} is required to inspect the ISO." >&2
21+
echo "error: ${command} is required to inspect the ISO (apt-get install genisoimage)." >&2
2222
exit 1
2323
fi
2424
done

0 commit comments

Comments
 (0)