Merge pull request #438 from JusterZhu/refactor/pipeline-fifo

refactor: PipelineBuilder LIFO to FIFO for intuitive middleware ordering

Author: JusterZhu

src/c#/GeneralUpdate.Core/Pipeline/PipelineBuilder.cs

@@ -5,19 +5,19 @@
 namespace GeneralUpdate.Core.Pipeline
 {
     /// <summary>
-    /// Pipeline builder.
+    /// Pipeline builder — middleware execute in FIFO (registration) order.
     /// </summary>
     public sealed class PipelineBuilder(PipelineContext context)
     {
         /// <summary>
-        /// LIFO£¬Last In First Out.
+        /// LIFO£¬Last In First Out.
         /// </summary>
-        private ImmutableStack<IMiddleware> _middlewareStack = ImmutableStack<IMiddleware>.Empty;
+        private ImmutableQueue<IMiddleware> _middlewareQueue = ImmutableQueue<IMiddleware>.Empty;
 
         public PipelineBuilder UseMiddleware<TMiddleware>() where TMiddleware : IMiddleware, new()
         {
             var middleware = new TMiddleware();
-            _middlewareStack = _middlewareStack.Push(middleware);
+            _middlewareQueue = _middlewareQueue.Enqueue(middleware);
             return this;
         }
 
@@ -28,13 +28,13 @@ public PipelineBuilder UseMiddlewareIf<TMiddleware>(bool? condition)
                 return this;
 
             var middleware = new TMiddleware();
-            _middlewareStack = _middlewareStack.Push(middleware);
+            _middlewareQueue = _middlewareQueue.Enqueue(middleware);
             return this;
         }
 
         public async Task Build()
         {
-            foreach (var middleware in _middlewareStack)
+            foreach (var middleware in _middlewareQueue)
             {
                 await middleware.InvokeAsync(context);
             }

src/c#/GeneralUpdate.Core/Strategy/LinuxStrategy.cs

@@ -20,9 +20,9 @@ protected override PipelineBuilder BuildPipeline(PipelineContext context)
     {
         GeneralTracer.Info($"GeneralUpdate.Core.LinuxStrategy.BuildPipeline: assembling middleware pipeline. PatchEnabled={_configinfo.PatchEnabled}");
         var builder = new PipelineBuilder(context)
-            .UseMiddlewareIf<PatchMiddleware>(_configinfo.PatchEnabled)
+            .UseMiddleware<HashMiddleware>()
             .UseMiddleware<CompressMiddleware>()
-            .UseMiddleware<HashMiddleware>();
+            .UseMiddlewareIf<PatchMiddleware>(_configinfo.PatchEnabled);
         return builder;
     }
 

src/c#/GeneralUpdate.Core/Strategy/MacStrategy.cs

@@ -52,9 +52,9 @@ protected override PipelineBuilder BuildPipeline(PipelineContext context)
     {
         GeneralTracer.Info($"MacStrategy.BuildPipeline: assembling middleware pipeline. PatchEnabled={_configinfo.PatchEnabled}");
         var builder = new PipelineBuilder(context)
-            .UseMiddlewareIf<PatchMiddleware>(_configinfo.PatchEnabled)
+            .UseMiddleware<HashMiddleware>()
             .UseMiddleware<CompressMiddleware>()
-            .UseMiddleware<HashMiddleware>();
+            .UseMiddlewareIf<PatchMiddleware>(_configinfo.PatchEnabled);
         return builder;
     }
 }

src/c#/GeneralUpdate.Core/Strategy/WindowsStrategy.cs

@@ -27,9 +27,9 @@ protected override PipelineBuilder BuildPipeline(PipelineContext context)
         {
             GeneralTracer.Info($"GeneralUpdate.Core.WindowsStrategy.BuildPipeline: assembling middleware pipeline. PatchEnabled={_configinfo.PatchEnabled}");
             var builder = new PipelineBuilder(context)
-                .UseMiddlewareIf<PatchMiddleware>(_configinfo.PatchEnabled)
+                .UseMiddleware<HashMiddleware>()
                 .UseMiddleware<CompressMiddleware>()
-                .UseMiddleware<HashMiddleware>();
+                .UseMiddlewareIf<PatchMiddleware>(_configinfo.PatchEnabled);
             return builder;
         }