Skip to content

[Bug]: remaining cargo metadata validation steps omit --format-version=1 #2616

Description

@1688mengdie

Remaining cargo metadata validation steps omit --format-version 1

Symptom

The release and nightly pipelines still call cargo metadata without an
explicit format version in four places:
.github/workflows/linux-binaries.yml lines 129 and 146, and
.github/workflows/nightly-artifacts.yml lines 161 and 207. When cargo
changes its default metadata output format, these steps print the same
compatibility warning that PR #2577 already eliminated for the three
calls in ci.yml.

Root cause

#2577 pinned --format-version 1 on the ci.yml validation steps and
the strict assertions in check-github-config.test.mjs that pin them,
but the two shared build workflows (linux-binaries.yml and
nightly-artifacts.yml) predate that change and were left with the bare
invocation.

Fix

Pass --format-version 1 explicitly in all four remaining steps, and
sync the strict command assertions in check-github-config.test.mjs
(lines 705, 801, 802) that pin these steps, mirroring the #2577 approach.

Verification

pnpm run check:github-config passes both stages locally (12 workflow
files parsed; contract tests 19 pass / 0 fail / 1 environment-dependent
skip covered by an equivalent assertion). Remote CI is the final judge.

Assisted-by: AI agent (Claude)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions