[Bug] API replace does not delete original file immediately.

[Forceu]

Discussed in #406

^{Originally posted by markcs May 19, 2026}
Has anyone seen that when using the API /files/replace and setting deleteNewFile to true, the original file is still not deleted from storage.

Is that by design and how to delete the file?

[Forceu]

Thank you for the report! Indeed that was not intentional, but with the current version, it the source file on the storage would have been deleted within one hour or if Gokapi restarts.

I have changed this in 7bd4405, so now it will be deleted right away.

[Forceu]

Discussed in #406

^{Originally posted by markcs May 19, 2026}

Thanks!
I pulled the latest changes and build the docker, but the file is not deleted.

sqlite> select * from FileMetaData;
UgKwBYzhfhOme3l|work.ics|993.9 kB|58a913238a034651052aab3303461dbcb94d600a|1779925652|1017737|0|184|||text/calendar||_EncryptionInfo��|1|1|1|1778716052|0|
sqlite> 

$ ls -l
total 4276
-rw------- 1 root root 1017737 May 19 21:30 58a913238a034651052aab3303461dbcb94d600a
-rw------- 1 root root 1017737 May 19 21:24 be3fe6d81bec41bf09314cb0385103e108e39ea9
-rw-r--r-- 1 root root   81920 May 19 21:12 gokapi.sqlite
-rw-r--r-- 1 root root   32768 May 19 21:34 gokapi.sqlite-shm
-rw-r--r-- 1 root root  354352 May 19 21:34 gokapi.sqlite-wal
-rw------- 1 root root 1857089 May 19 21:30 log.txt

$ ls -l
total 5336
-rw------- 1 root root 1017737 May 19 21:30 58a913238a034651052aab3303461dbcb94d600a
-rw------- 1 root root 1017738 May 19 21:37 6ea6eb3fa852ee4ae923e56910a820fd628107fc
-rw------- 1 root root 1017737 May 19 21:24 be3fe6d81bec41bf09314cb0385103e108e39ea9
-rw-r--r-- 1 root root   81920 May 19 21:12 gokapi.sqlite
-rw-r--r-- 1 root root   32768 May 19 21:37 gokapi.sqlite-shm
-rw-r--r-- 1 root root  420272 May 19 21:37 gokapi.sqlite-wal
-rw------- 1 root root 1857333 May 19 21:37 log.txt
$ sqlite3 gokapi.sqlite 
SQLite version 3.45.1 2024-01-30 16:01:20
Enter ".help" for usage hints.
sqlite> select * from FileMetaData;
UgKwBYzhfhOme3l|work.ics|993.9 kB|6ea6eb3fa852ee4ae923e56910a820fd628107fc|1779925652|1017738|0|184|||text/calendar||_EncryptionInfo��|1|1|1|1778716052|0|
sqlite> 

[Forceu]

@markcs: Thanks for the feedback!

Can you try with the latest docker image gokapi:latest-dev, if the problem is there is as well?

[markcs]

I pulled the dev version and still the same issue. After uploading a file and using the replace api, I still have 'orphaned' files on my system. Maybe I'm misunderstanding how this should work?

In the test below, there should only be one file left in storage after the replace, however the file '181e94bf84bc01441a48fd97f78c706317983667' remains.

me@vm1:~/docker/gokapi/data$ ls -l
total 244
-rw------- 1 root root      4 May 20 03:47 181e94bf84bc01441a48fd97f78c706317983667
-rw------- 1 root root     14 May 20 03:48 ae9a21063babc425daf7d4dc1031df7645381e41
-rw-r--r-- 1 root root  81920 May 20 03:44 gokapi.sqlite
-rw-r--r-- 1 root root  32768 May 20 03:48 gokapi.sqlite-shm
-rw-r--r-- 1 root root 115392 May 20 03:48 gokapi.sqlite-wal
-rw------- 1 root root    514 May 20 03:48 log.txt
me@vm1:~/docker/gokapi/data$ sqlite3 gokapi.sqlite 'select * from FileMetaData;'
yDKiUO4h4nrX2y2|testfile.txt|4 B|181e94bf84bc01441a48fd97f78c706317983667|1780458473|4|0|0|||text/plain||_EncryptionInfo��|1|0|1|1779248873|0|
x4XrvWwxa06iEi9|testfile - 2.txt|14 B|ae9a21063babc425daf7d4dc1031df7645381e41|1780458525|14|0|0|||text/plain||_EncryptionInfo��|1|0|1|1779248925|0|
me@vm1:~/docker/gokapi/data$ echo replace yDKiUO4h4nrX2y2 with x4XrvWwxa06iEi9
replace yDKiUO4h4nrX2y2 with x4XrvWwxa06iEi9
me@vm1:~/docker/gokapi/data$ sqlite3 gokapi.sqlite 'select * from FileMetaData;'
x4XrvWwxa06iEi9|testfile - 2.txt|14 B|ae9a21063babc425daf7d4dc1031df7645381e41|1780458525|14|0|0|||text/plain||_EncryptionInfo��|1|0|1|1779248925|0|
me@vm1:~/docker/gokapi/data$ ls -l
total 292
-rw------- 1 root root      4 May 20 03:47 181e94bf84bc01441a48fd97f78c706317983667
-rw------- 1 root root     14 May 20 03:48 ae9a21063babc425daf7d4dc1031df7645381e41
-rw-r--r-- 1 root root  81920 May 20 03:44 gokapi.sqlite
-rw-r--r-- 1 root root  32768 May 20 03:50 gokapi.sqlite-shm
-rw-r--r-- 1 root root 164832 May 20 03:50 gokapi.sqlite-wal
-rw------- 1 root root    670 May 20 03:49 log.txt