PluginSettingsWindow: Remove constructor that could lead to invalid state and merge LoadPlugin Method into remaining constructor

Author: DavidGBrett

Flow.Launcher/PluginSettingsWindow.xaml.cs

@@ -13,20 +13,10 @@ public partial class PluginSettingsWindow
 {
     private readonly Settings _settings;
 
-    public PluginSettingsWindow()
-    {
-        _settings = Ioc.Default.GetRequiredService<Settings>();
-        InitializeComponent();
-    }
-
     public PluginSettingsWindow(string pluginId)
-        : this()
     {
-        LoadPlugin(pluginId);
-    }
+        _settings = Ioc.Default.GetRequiredService<Settings>();
 
-    private void LoadPlugin(string pluginId)
-    {
         if (string.IsNullOrWhiteSpace(pluginId))
         {
             App.API.ShowMsgError("Plugin settings", "Invalid plugin id.");
@@ -56,6 +46,8 @@ private void LoadPlugin(string pluginId)
 
         DataContext = pluginViewModel;
         Title = $"{pluginPair.Metadata.Name} Settings";
+
+        InitializeComponent();
     }
 
     // This is used for Priority control to force its value to be 0 when the user clears the value.