Skip to content

Commit ba1908d

Browse files
committed
Update plugin min version warning message formatting
Improved the message shown when a plugin requires a newer Flow Launcher version by adding line breaks for clarity and updating the title wording. Adjusted code to pass Environment.NewLine and modified resource strings in en.xaml to support the new format.
1 parent 590bf20 commit ba1908d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

Flow.Launcher.Core/Plugin/PluginManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ internal static bool InstallPlugin(UserPlugin plugin, string zipFilePath, bool c
922922
{
923923
// Ask users if they want to install the plugin that doesn't satisfy the minimum app version requirement
924924
if (PublicApi.Instance.ShowMsgBox(
925-
Localize.pluginMinimumAppVersionUnsatisfiedMessage(newMetadata.Name),
925+
Localize.pluginMinimumAppVersionUnsatisfiedMessage(newMetadata.Name, Environment.NewLine),
926926
Localize.pluginMinimumAppVersionUnsatisfiedTitle(newMetadata.Name, newMetadata.MinimumAppVersion),
927927
MessageBoxButton.YesNo) == MessageBoxResult.No)
928928
{
@@ -1092,7 +1092,7 @@ internal static bool IsMinimumAppVersionSatisfied(string pluginName, string mini
10921092
}
10931093

10941094
if (appVersion >= minimumVersion)
1095-
return true;
1095+
return true;
10961096

10971097
PublicApi.Instance.LogInfo(ClassName, $"Plugin {pluginName} requires minimum Flow Launcher version {minimumAppVersion}, "
10981098
+ $"but current version is {Constant.Version}. Plugin excluded from manifest.");

Flow.Launcher/Languages/en.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,8 @@
232232
<system:String x:Key="fileNotFoundMessage">Unable to find plugin.json from the extracted zip file, or this path {0} does not exist</system:String>
233233
<system:String x:Key="pluginExistAlreadyMessage">A plugin with the same ID and version already exists, or the version is greater than this downloaded plugin</system:String>
234234
<system:String x:Key="errorCreatingSettingPanel">Error creating setting panel for plugin {0}:{1}{2}</system:String>
235-
<system:String x:Key="pluginMinimumAppVersionUnsatisfiedTitle">{0} requires Flow {1}+ version to run</system:String>
236-
<system:String x:Key="pluginMinimumAppVersionUnsatisfiedMessage">Flow does not meet the minimum version requirements for {0} to run. Do you want to continue installing it? We recommend updating Flow to the latest version to ensure that {0} works without issues.</system:String>
235+
<system:String x:Key="pluginMinimumAppVersionUnsatisfiedTitle">{0} requires Flow {1} version to run</system:String>
236+
<system:String x:Key="pluginMinimumAppVersionUnsatisfiedMessage">Flow does not meet the minimum version requirements for {0} to run. Do you want to continue installing it?{1}{1}We recommend updating Flow to the latest version to ensure that {0} works without issues.</system:String>
237237
<system:String x:Key="pluginJsonInvalidOrCorrupted">Failed to install plugin because plugin.json is invalid or corrupted</system:String>
238238

239239
<!-- Setting Plugin Store -->

0 commit comments

Comments
 (0)