bug in example / fnft_kdvv_example.c

[xmhk]

In: 0.5 release / master branch
when compiled, the kdvv c-example (examples/fnft_kdvv_example.c) fails:

FNFT Error: Invalid argument opts->grid_spacing.
 in kdvv_compute_boundstates(593)-0.5.0
FNFT Error: Subroutine failure.
 in fnft_kdvv_base(480)-0.5.0
FNFT Error: Subroutine failure.
 in fnft_kdvv(242)-0.5.0
An error occured!

I suppose this is due to using the default grid-spacing of 0.0.
The example works fine if the grid spacing is explicitly defined, e.g. as

fnft_kdvv_opts_t opts = fnft_kdvv_default_opts();
// define grid spacing 
opts.grid_spacing = 0.001;

Best, Christoph

[wahls]

Hi Christoph,

Many thanks for reporting. The grid_spacing default is intentionally set to zero, so that the user has to choose this (important parameter) him-/herself. There are other algorithms for the discrete vKdV spectrum that do not utilize a grid (not implemented yet), which is why I did not make it a main argument for the function.

I'll put this on the list of things to fix for 0.5.1. If you notice anything else, please let me know.

Best, Sander