MID-11082 Avoid retaining LensContext in preview page#660
Open
kay1313 wants to merge 1 commit into
Open
Conversation
Preview changes kept live ModelContext instances in Wicket page state. In some flows, these contexts include policy rule evaluation state with MagicAssignment/Holder objects that Wicket cannot serialize. Extract preview UI data before rendering and keep only serializable DTO state in the page and tab panels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MID-11082 by avoiding retention of live
ModelContext/LensContextinstances in the focus preview changes page.PageFocusPreviewChangespreviously passed live model contexts intoPreviewChangesTabPanel. In some policy-rule preview flows, these contexts contain evaluated assignment state with assignment path variables, includingMagicAssignment/Holderobjects that are not suitable for Wicket serialization.The preview page now extracts the data needed by the UI into serializable preview DTOs before rendering, and the tab panels keep only this preview data.
Changes
ModelContextdata to serializablePreviewData.Model.of(modelContext)intoPreviewChangesTabPanel.PreviewChangesTabPaneluse DTO/list state instead of live model context.