fix: fixed error return bug

Author: DavidsonGomes

CHANGELOG.md

@@ -1,3 +1,9 @@
+# 1.4.7 (2023-07-26 17:54)
+
+### Fixed
+
+* Fixed error return bug
+
 # 1.4.6 (2023-07-26 17:54)
 
 ### Fixed

src/exceptions/400.exception.ts

@@ -2,6 +2,7 @@ import { HttpStatus } from '../whatsapp/routers/index.router';
 
 export class BadRequestException {
   constructor(...objectError: any[]) {
+    console.log('BadRequestException', objectError);
     throw {
       status: HttpStatus.BAD_REQUEST,
       error: 'Bad Request',

src/main.ts

@@ -1,18 +1,15 @@
-import 'express-async-errors';
-
-// import * as Sentry from '@sentry/node';
 import compression from 'compression';
+import { configService, Cors, HttpServer } from './config/env.config';
 import cors from 'cors';
 import express, { json, NextFunction, Request, Response, urlencoded } from 'express';
 import { join } from 'path';
-
-import { configService, Cors, HttpServer } from './config/env.config';
 import { onUnexpectedError } from './config/error.config';
 import { Logger } from './config/logger.config';
 import { ROOT_DIR } from './config/path.config';
-import { ServerUP } from './utils/server-up';
-import { HttpStatus, router } from './whatsapp/routers/index.router';
 import { waMonitor } from './whatsapp/whatsapp.module';
+import { HttpStatus, router } from './whatsapp/routers/index.router';
+import 'express-async-errors';
+import { ServerUP } from './utils/server-up';
 
 function initWA() {
   waMonitor.loadInstance();
@@ -22,27 +19,6 @@ function bootstrap() {
   const logger = new Logger('SERVER');
   const app = express();
 
-  // Sentry.init({
-  //   dsn: '',
-  //   integrations: [
-  //     // enable HTTP calls tracing
-  //     new Sentry.Integrations.Http({ tracing: true }),
-  //     // enable Express.js middleware tracing
-  //     new Sentry.Integrations.Express({ app }),
-  //     // Automatically instrument Node.js libraries and frameworks
-  //     ...Sentry.autoDiscoverNodePerformanceMonitoringIntegrations(),
-  //   ],
-
-  //   // Set tracesSampleRate to 1.0 to capture 100%
-  //   // of transactions for performance monitoring.
-  //   // We recommend adjusting this value in production
-  //   tracesSampleRate: 1.0,
-  // });
-
-  // app.use(Sentry.Handlers.requestHandler());
-
-  // app.use(Sentry.Handlers.tracingHandler());
-
   app.use(
     cors({
       origin(requestOrigin, callback) {
@@ -67,18 +43,13 @@ function bootstrap() {
 
   app.use('/', router);
 
-  // app.use(Sentry.Handlers.errorHandler());
-
-  // app.use(function onError(err, req, res, next) {
-  //   res.statusCode = 500;
-  //   res.end(res.sentry + '\n');
-  // });
-
   app.use(
-    (err: Error, req: Request, res: Response) => {
+    (err: Error, req: Request, res: Response, next: NextFunction) => {
       if (err) {
         return res.status(err['status'] || 500).json(err);
       }
+
+      next();
     },
     (req: Request, res: Response, next: NextFunction) => {
       const { method, url } = req;

src/whatsapp/abstract/abstract.router.ts

@@ -6,7 +6,7 @@ import { validate } from 'jsonschema';
 
 import { Logger } from '../../config/logger.config';
 import { BadRequestException } from '../../exceptions';
-import { GetParticipant, GroupInvite, GroupJid } from '../dto/group.dto';
+import { GetParticipant, GroupInvite } from '../dto/group.dto';
 import { InstanceDto } from '../dto/instance.dto';
 
 type DataValidate<T> = {
@@ -105,23 +105,23 @@ export abstract class RouterBroker {
     const body = request.body;
 
     let groupJid = body?.groupJid;
-    
+
     if (!groupJid) {
       if (request.query?.groupJid) {
         groupJid = request.query.groupJid;
       } else {
         throw new BadRequestException('The group id needs to be informed in the query', 'ex: "groupJid=120362@g.us"');
       }
     }
-    
+
     if (!groupJid.endsWith('@g.us')) {
       groupJid = groupJid + '@g.us';
     }
-    
+
     Object.assign(body, {
-      groupJid: groupJid
+      groupJid: groupJid,
     });
-    
+
     const ref = new ClassRef();
 
     Object.assign(ref, body);

src/whatsapp/controllers/settings.controller.ts

@@ -12,7 +12,6 @@ export class SettingsController {
   constructor(private readonly settingsService: SettingsService) {}
 
   public async createSettings(instance: InstanceDto, data: SettingsDto) {
-
     logger.verbose('requested createSettings from ' + instance.instanceName + ' instance');
 
     return this.settingsService.create(instance, data);

src/whatsapp/repository/repository.manager.ts

@@ -109,7 +109,6 @@ export class RepositoryBroker {
           this.logger.verbose('creating temp dir: ' + tempDir);
           fs.mkdirSync(tempDir, { recursive: true });
         }
-
       } catch (error) {
         this.logger.error(error);
       }