Skip to content

get_fundamentals_data should return dict, not list #71

@AnthonyTedde

Description

@AnthonyTedde

Hello EODHD Team,

It seems there may be a typing issue in the Python client for the method defined here:

apiclient.py#get_fundamentals_data

def get_fundamentals_data(
    self,
    ticker: str,
    filter: str = None,
    historical: int = None,
    from_date: str = None,
    to_date: str = None,
    version: int = None,
    no_cache: int = None
) -> list:

The method appears to return a dictionary/object rather than a list, so the return type annotation may be incorrect and should probably be dict instead of list.

This can lead to misleading type hints and IDE/type-checking issues for users of the library.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions