From 5095f2643f0d15374009d3971f389ff8646c42bb Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Sun, 23 Aug 2026 13:09:21 +0000
Subject: [PATCH] feat: Add physical key styling to keyboard instructions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Added `<kbd>` tags and corresponding CSS to `src/views/mario-game.njk` to highlight keyboard shortcuts ("Space" and "↑"). The custom CSS in the internal `<style>` block provides a physical key appearance with text shadows, improving discoverability and visual distinction against the background. Also logged the UX learning to `.Jules/palette.md`.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
---
 .Jules/palette.md        |  4 ++++
 src/views/mario-game.njk | 16 +++++++++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/.Jules/palette.md b/.Jules/palette.md
index 49b0751..fdc5e77 100644
--- a/.Jules/palette.md
+++ b/.Jules/palette.md
@@ -19,3 +19,7 @@
 ## 2024-08-06 - Screen Reader Accessible Dynamic Text
 **Learning:** Dynamic text changes, like game scores, are invisible to screen readers unless explicitly marked. Do not place static text (like instructions) inside an `aria-live` region, as it forces screen readers to unnecessarily repeat the static text every time the dynamic content updates. Extract static text into a separate sibling element.
 **Action:** Add `aria-live="polite"` to the container of the dynamic value and extract static text out of it.
+
+## 2025-10-10 - Keyboard Shortcut Semantics
+**Learning:** Explicitly highlighting keyboard shortcuts using semantic <kbd> tags with physical key styling improves intuitiveness and discoverability against dynamic backgrounds.
+**Action:** Always wrap key shortcuts in <kbd> and apply text-shadows to ensure high contrast and visual distinction for keyboard instructions.
diff --git a/src/views/mario-game.njk b/src/views/mario-game.njk
index c84e3f2..55b99e5 100644
--- a/src/views/mario-game.njk
+++ b/src/views/mario-game.njk
@@ -62,6 +62,20 @@
       font-family: Arial;
       pointer-events: none;
     }
+    kbd {
+      background-color: #eee;
+      border-radius: 3px;
+      border: 1px solid #b4b4b4;
+      box-shadow: 0 1px 1px rgba(0,0,0,.2), 0 2px 0 0 rgba(255,255,255,.7) inset;
+      color: #333;
+      display: inline-block;
+      font-size: 14px;
+      font-weight: 700;
+      line-height: 1;
+      padding: 2px 4px;
+      white-space: nowrap;
+      text-shadow: 0 1px 0 #fff;
+    }
   </style>
 </head>
 
@@ -69,7 +83,7 @@
 
 <div id="game">
   <div id="score-container">Score: <span id="score-value" aria-live="polite">0</span></div>
-  <div id="instructions">Press Space or ↑ to jump!</div>
+  <div id="instructions">Press <kbd>Space</kbd> or <kbd>↑</kbd> to jump!</div>
   <div id="mario"></div>
   <div class="ground"></div>
 </div>