From ddadd6b55b4dcb6152e573054b5ed81ea749515a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez=20Rivero?= Date: Fri, 31 Jul 2026 12:56:17 +0200 Subject: [PATCH 1/3] Change Number.parse to parseFloat in schema migration Number.parse does not exist. Used parseFloat to make it consistent with previous V3 example --- migration/schema.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/schema.md b/migration/schema.md index 5f31f09504a..c69fd435c50 100644 --- a/migration/schema.md +++ b/migration/schema.md @@ -903,7 +903,7 @@ import { Effect, Number, Option, Schema, SchemaGetter, SchemaIssue } from "effec const NumberFromString = Schema.String.pipe( Schema.decodeTo(Schema.Number, { decode: SchemaGetter.transformOrFail((s) => { - const n = Number.parse(s) + const n = parseFloat(s) if (n === undefined) { return Effect.fail(new SchemaIssue.InvalidValue(Option.some(s))) } From 2214a1df63b672fbba5ae2b4d19c9330928ad7a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez=20Rivero?= Date: Fri, 31 Jul 2026 13:47:14 +0200 Subject: [PATCH 2/3] address PR comments --- migration/schema.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/schema.md b/migration/schema.md index c69fd435c50..52d031ff89d 100644 --- a/migration/schema.md +++ b/migration/schema.md @@ -904,7 +904,7 @@ const NumberFromString = Schema.String.pipe( Schema.decodeTo(Schema.Number, { decode: SchemaGetter.transformOrFail((s) => { const n = parseFloat(s) - if (n === undefined) { + if (isNaN(parsed)) { return Effect.fail(new SchemaIssue.InvalidValue(Option.some(s))) } return Effect.succeed(n) From ebecf2847ab0a02f1e71fd4f5f28014f3763eeb5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez=20Rivero?= Date: Fri, 31 Jul 2026 13:51:59 +0200 Subject: [PATCH 3/3] chore: use better variable names --- migration/schema.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/schema.md b/migration/schema.md index 52d031ff89d..0931ca13da9 100644 --- a/migration/schema.md +++ b/migration/schema.md @@ -903,11 +903,11 @@ import { Effect, Number, Option, Schema, SchemaGetter, SchemaIssue } from "effec const NumberFromString = Schema.String.pipe( Schema.decodeTo(Schema.Number, { decode: SchemaGetter.transformOrFail((s) => { - const n = parseFloat(s) + const parsed = parseFloat(s) if (isNaN(parsed)) { return Effect.fail(new SchemaIssue.InvalidValue(Option.some(s))) } - return Effect.succeed(n) + return Effect.succeed(parsed) }), encode: SchemaGetter.String() })