From 6ba72b1904b7059af2184244482f16c00df490d8 Mon Sep 17 00:00:00 2001 From: Tom Tang <4220945+shiba4life@users.noreply.github.com> Date: Tue, 12 May 2026 12:15:18 +0800 Subject: [PATCH] refactor(constants/api): drop 3 dead exports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - API_BATCH_REQUEST_LIMIT — declared in constants/api.ts and re-exported in api/index.ts; zero consumers anywhere in src/server/static-react/. - SCHEMA_OPERATIONS — declared, re-exported from the barrel, and named in schemaClient.ts's import list but never used in the body; no dynamic SCHEMA_OPERATIONS[...] access either. - API_BASE_URLS re-export in constants/api.ts — the sole consumer (ingestionClient.ts) already imports it directly from api/endpoints (the canonical generated source). The barrel api/index.ts doesn't re-export it, so the constants/api.ts re-export was unreachable. Sibling cleanup to #1013 (SCHEMA_ACTION_TYPES); same audit pattern, constants/api.ts was carved out of that PR's scope. Net: pure deletion across 3 files (-19/+2). api/endpoints.ts (canonical API_BASE_URLS) untouched. Verified: npm run typecheck, npm test (788 tests pass). Co-Authored-By: Claude Opus 4.7 (1M context) --- .../static-react/src/api/clients/schemaClient.ts | 2 +- src/server/static-react/src/api/index.ts | 4 +--- src/server/static-react/src/constants/api.ts | 15 --------------- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/src/server/static-react/src/api/clients/schemaClient.ts b/src/server/static-react/src/api/clients/schemaClient.ts index 5aff5166..24d335aa 100644 --- a/src/server/static-react/src/api/clients/schemaClient.ts +++ b/src/server/static-react/src/api/clients/schemaClient.ts @@ -2,7 +2,7 @@ import { ApiClient, getSharedClient } from '../core/client'; import { API_ENDPOINTS } from '../endpoints'; -import { SCHEMA_STATES, SCHEMA_OPERATIONS, API_TIMEOUTS, API_RETRIES, API_CACHE_TTL, CACHE_KEYS } from '../../constants/api'; +import { SCHEMA_STATES, API_TIMEOUTS, API_RETRIES, API_CACHE_TTL, CACHE_KEYS } from '../../constants/api'; import type { EnhancedApiResponse } from '../core/types'; import type { Schema, SchemaState } from '../../types/schema'; import { normalizeSchemaState } from '../../utils/rangeSchemaHelpers.js'; diff --git a/src/server/static-react/src/api/index.ts b/src/server/static-react/src/api/index.ts index f89de98f..a7900c36 100644 --- a/src/server/static-react/src/api/index.ts +++ b/src/server/static-react/src/api/index.ts @@ -88,7 +88,6 @@ export { API_REQUEST_TIMEOUT_MS, API_RETRY_ATTEMPTS, API_RETRY_DELAY_MS, - API_BATCH_REQUEST_LIMIT, HTTP_STATUS_CODES, CONTENT_TYPES, REQUEST_HEADERS, @@ -96,8 +95,7 @@ export { CACHE_CONFIG, RETRY_CONFIG, API_CONFIG, - SCHEMA_STATES, - SCHEMA_OPERATIONS + SCHEMA_STATES } from '../constants/api'; export { API_ENDPOINTS } from './endpoints'; diff --git a/src/server/static-react/src/constants/api.ts b/src/server/static-react/src/constants/api.ts index 14d0ea73..e5bb1e67 100644 --- a/src/server/static-react/src/constants/api.ts +++ b/src/server/static-react/src/constants/api.ts @@ -3,13 +3,11 @@ * Centralized API configuration for API-STD-1 compliance * Extracted from repeated patterns across API clients for DRY enforcement */ -import { API_BASE_URLS as GENERATED_API_BASE_URLS } from "../api/endpoints"; // Base Request Configuration export const API_REQUEST_TIMEOUT_MS = 30000; export const API_RETRY_ATTEMPTS = 3; export const API_RETRY_DELAY_MS = 1000; -export const API_BATCH_REQUEST_LIMIT = 20; // Operation-Specific Timeout Values export const API_TIMEOUTS = { @@ -58,9 +56,6 @@ export const API_CACHE_TTL = { MUTATION_HISTORY: 300000, } as const; -// API Base URLs (generated from Rust OpenAPI via endpoints.ts) -export const API_BASE_URLS = GENERATED_API_BASE_URLS; - // HTTP Status Codes export const HTTP_STATUS_CODES = { OK: 200, @@ -140,16 +135,6 @@ export const API_CONFIG = { import { SCHEMA_STATES } from "./schemas"; export { SCHEMA_STATES }; -// Schema Operation Types -export const SCHEMA_OPERATIONS = { - READ: "read", - WRITE: "write", - APPROVE: "approve", - BLOCK: "block", - MUTATION: "mutation", - QUERY: "query", -} as const; - // Cache Key Prefixes export const CACHE_KEYS = { SCHEMAS: "schemas",