From 24320bfaad34c0313ac7c273561d6272c5a6dc59 Mon Sep 17 00:00:00 2001
From: Tom Tang <4220945+shiba4life@users.noreply.github.com>
Date: Tue, 12 May 2026 07:31:54 +0800
Subject: [PATCH] refactor(progress): dedupe 4 identical SystemTime::now()
 blocks via now_secs() helper
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replaces 4 identical SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs()
chains in Job::new/update_progress/complete/fail with a single private now_secs() helper.
Behavior-preserving (preserves .unwrap_or_default semantics — returns 0 on clock-before-epoch).
Single-file change.
---
 crates/core/src/progress.rs | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/crates/core/src/progress.rs b/crates/core/src/progress.rs
index b9604181..b70eb916 100644
--- a/crates/core/src/progress.rs
+++ b/crates/core/src/progress.rs
@@ -9,6 +9,13 @@ use std::collections::HashMap;
 use std::sync::{Arc, Mutex};
 use utoipa::ToSchema;
 
+fn now_secs() -> u64 {
+    std::time::SystemTime::now()
+        .duration_since(std::time::UNIX_EPOCH)
+        .unwrap_or_default()
+        .as_secs()
+}
+
 /// Type of job being tracked
 #[derive(Debug, Clone, Serialize, Deserialize, ToSchema, PartialEq)]
 pub enum JobType {
@@ -63,10 +70,7 @@ pub struct Job {
 
 impl Job {
     pub fn new(id: String, job_type: JobType) -> Self {
-        let now = std::time::SystemTime::now()
-            .duration_since(std::time::UNIX_EPOCH)
-            .unwrap_or_default()
-            .as_secs();
+        let now = now_secs();
 
         Self {
             id,
@@ -98,10 +102,7 @@ impl Job {
         self.progress_percentage = percentage.min(100);
         self.message = message;
         self.status = JobStatus::Running;
-        self.updated_at = std::time::SystemTime::now()
-            .duration_since(std::time::UNIX_EPOCH)
-            .unwrap_or_default()
-            .as_secs();
+        self.updated_at = now_secs();
     }
 
     pub fn complete(&mut self, result: Option<serde_json::Value>) {
@@ -109,10 +110,7 @@ impl Job {
         self.progress_percentage = 100;
         self.message = "Completed".to_string();
         self.result = result;
-        let now = std::time::SystemTime::now()
-            .duration_since(std::time::UNIX_EPOCH)
-            .unwrap_or_default()
-            .as_secs();
+        let now = now_secs();
         self.updated_at = now;
         self.completed_at = Some(now);
     }
@@ -121,10 +119,7 @@ impl Job {
         self.status = JobStatus::Failed;
         self.error = Some(error.clone());
         self.message = format!("Failed: {}", error);
-        let now = std::time::SystemTime::now()
-            .duration_since(std::time::UNIX_EPOCH)
-            .unwrap_or_default()
-            .as_secs();
+        let now = now_secs();
         self.updated_at = now;
         self.completed_at = Some(now);
     }