feat: forbid proxying over HTTPS

LexLuengas · LexLuengas · commit d0c5543b6acf · 2022-09-09T08:57:08.000+02:00
diff --git a/src/cli.ts b/src/cli.ts
@@ -19,7 +19,7 @@ program //
   .option('-p, --port <port>', 'port number on which to run the proxy', 8888)
   .option(
     '-t, --target <target>',
-    'full base path of the target API (format: http(s)://host:port/basePath)',
+    'full base path of the target API (format: http://host:port/basePath)',
   )
   .option(
     '--default-forbid-additional-properties',
@@ -69,6 +69,10 @@ if (isNaN(Number(targetPort))) {
     process.exit();
   }
 }
+if (program.target.startsWith('https://')) {
+  console.log('HTTPS is not supported. Not possible to modify requests/responses when the channel is encrypted. Consider to use openapi-cop behind a SSL proxy.\n');
+  process.exit();
+}
 if (
   program.target.indexOf('//localhost') !== -1 &&
   program.target.indexOf('//0.0.0.0') !== -1 &&

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ program //`
`19`	`19`	`.option('-p, --port <port>', 'port number on which to run the proxy', 8888)`
`20`	`20`	`.option(`
`21`	`21`	`'-t, --target <target>',`
`22`		`- 'full base path of the target API (format: http(s)://host:port/basePath)',`
	`22`	`+ 'full base path of the target API (format: http://host:port/basePath)',`
`23`	`23`	`)`
`24`	`24`	`.option(`
`25`	`25`	`'--default-forbid-additional-properties',`
`@@ -69,6 +69,10 @@ if (isNaN(Number(targetPort))) {`
`69`	`69`	`process.exit();`
`70`	`70`	`}`
`71`	`71`	`}`
	`72`	`+if (program.target.startsWith('https://')) {`
	`73`	`+ console.log('HTTPS is not supported. Not possible to modify requests/responses when the channel is encrypted. Consider to use openapi-cop behind a SSL proxy.\n');`
	`74`	`+ process.exit();`
	`75`	`+}`
`72`	`76`	`if (`
`73`	`77`	`program.target.indexOf('//localhost') !== -1 &&`
`74`	`78`	`program.target.indexOf('//0.0.0.0') !== -1 &&`