Skip to content

Commit a71a65f

Browse files
committed
Fix smoke tests: CLANG64 runtime for Windows, debug stderr on error
1. smoke-windows: Use CLANG64 (not UCRT64) so runtime matches the build environment. Binary built with CLANG64 needs CLANG64 DLLs. 2. smoke-unix: Add fail-fast: false so one platform failure doesn't cancel all 7 other smoke jobs. 3. smoke-test.sh: Capture and display stderr on indexing failure to help debug smoke-unix errors. 4. release.yml: Same CLANG64 smoke fix.
1 parent 0e9a471 commit a71a65f

3 files changed

Lines changed: 18 additions & 11 deletions

File tree

.github/workflows/dry-run.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ jobs:
231231
if: ${{ !inputs.skip_builds }}
232232
needs: [build-unix]
233233
strategy:
234+
fail-fast: false
234235
matrix:
235236
include:
236237
- os: ubuntu-latest
@@ -275,20 +276,21 @@ jobs:
275276

276277
- uses: msys2/setup-msys2@v2
277278
with:
278-
msystem: UCRT64
279+
msystem: CLANG64
279280
path-type: inherit
280281
install: >-
281-
mingw-w64-ucrt-x86_64-python3
282+
mingw-w64-clang-x86_64-python3
283+
unzip
282284
283285
- uses: actions/download-artifact@v4
284286
with:
285287
name: binaries-windows-amd64
286288

287289
- name: Extract binary
288-
shell: pwsh
290+
shell: msys2 {0}
289291
run: |
290-
$suffix = if ("${{ matrix.variant }}" -eq "ui") { "-ui" } else { "" }
291-
Expand-Archive -Path "codebase-memory-mcp${suffix}-windows-amd64.zip" -DestinationPath .
292+
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
293+
unzip -o "codebase-memory-mcp${SUFFIX}-windows-amd64.zip"
292294
293295
- name: Smoke test (${{ matrix.variant }}, windows-amd64)
294296
shell: msys2 {0}

.github/workflows/release.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -269,20 +269,21 @@ jobs:
269269

270270
- uses: msys2/setup-msys2@v2
271271
with:
272-
msystem: UCRT64
272+
msystem: CLANG64
273273
path-type: inherit
274274
install: >-
275-
mingw-w64-ucrt-x86_64-python3
275+
mingw-w64-clang-x86_64-python3
276+
unzip
276277
277278
- uses: actions/download-artifact@v4
278279
with:
279280
name: binaries-windows-amd64
280281

281282
- name: Extract binary
282-
shell: pwsh
283+
shell: msys2 {0}
283284
run: |
284-
$suffix = if ("${{ matrix.variant }}" -eq "ui") { "-ui" } else { "" }
285-
Expand-Archive -Path "codebase-memory-mcp${suffix}-windows-amd64.zip" -DestinationPath .
285+
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
286+
unzip -o "codebase-memory-mcp${SUFFIX}-windows-amd64.zip"
286287
287288
- name: Smoke test (${{ matrix.variant }}, windows-amd64)
288289
shell: msys2 {0}

scripts/smoke-test.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ BINARY="${1:?usage: smoke-test.sh <binary-path>}"
1313
TMPDIR=$(mktemp -d)
1414
trap 'rm -rf "$TMPDIR"' EXIT
1515

16-
cli() { "$BINARY" cli "$@" 2>/dev/null; }
16+
CLI_STDERR=$(mktemp)
17+
cli() { "$BINARY" cli "$@" 2>"$CLI_STDERR"; }
1718

1819
echo "=== Phase 1: version ==="
1920
OUTPUT=$("$BINARY" --version 2>&1)
@@ -97,6 +98,9 @@ echo "$RESULT"
9798
STATUS=$(echo "$RESULT" | python3 -c "import json,sys; d=json.loads(json.loads(sys.stdin.read())['content'][0]['text']); print(d.get('status',''))" 2>/dev/null || echo "")
9899
if [ "$STATUS" != "indexed" ]; then
99100
echo "FAIL: index status is '$STATUS', expected 'indexed'"
101+
echo "--- stderr ---"
102+
cat "$CLI_STDERR"
103+
echo "--- end stderr ---"
100104
exit 1
101105
fi
102106

0 commit comments

Comments
 (0)