fix(k8s): address QA round 3 findings

- Check return value of cbm_pipeline_pass_k8s() in incremental path;
  log warning on failure (fail-open, matches full pipeline behaviour)
- Add comment documenting pass ordering and the two known structural
  limitations: File→Resource DEFINES edges and cross-file kustomize
  IMPORTS edges are not emitted in incremental (gbuf only contains
  nodes for changed files; File nodes from pass_structure are absent)
- Fix clang-format violation in incremental_kustomize_module_indexed
  test (single-line if condition)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: shanemccarron-maker

src/pipeline/pipeline_incremental.c

@@ -265,8 +265,16 @@ int cbm_pipeline_run_incremental(cbm_pipeline_t *p, const char *db_path, cbm_fil
     cbm_log_info("pass.timing", "pass", "incr_semantic", "elapsed_ms",
                  itoa_buf((int)elapsed_ms(t)));
 
+    /* k8s pass runs after semantic (vs. after definitions in the full pipeline) because
+     * incremental has no parallel extraction phase to position it alongside.
+     * Note: File→Resource DEFINES edges and cross-file kustomize IMPORTS edges are not
+     * emitted here — File nodes (from pass_structure) are absent in the incremental gbuf,
+     * and gbuf_find_by_qn only resolves nodes from changed files.  This is a known
+     * structural limitation of the incremental architecture. */
     cbm_clock_gettime(CLOCK_MONOTONIC, &t);
-    cbm_pipeline_pass_k8s(&ctx, changed_files, ci);
+    if (cbm_pipeline_pass_k8s(&ctx, changed_files, ci) != 0) {
+        cbm_log_info("incremental.warn", "msg", "k8s_pass_failed");
+    }
     cbm_log_info("pass.timing", "pass", "incr_k8s", "elapsed_ms", itoa_buf((int)elapsed_ms(t)));
 
     /* Merge new nodes/edges from gbuf into disk DB */

tests/test_pipeline.c

@@ -5197,8 +5197,7 @@ TEST(incremental_kustomize_module_indexed) {
     cbm_store_find_nodes_by_label(s, project, "Module", &nodes, &count);
     bool found_kust = false;
     for (int i = 0; i < count; i++) {
-        if (nodes[i].properties_json &&
-            strstr(nodes[i].properties_json, "kustomize")) {
+        if (nodes[i].properties_json && strstr(nodes[i].properties_json, "kustomize")) {
             found_kust = true;
             break;
         }